Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMZA-2147: Improve the documentation of the samza release process. #974

Merged
merged 2 commits into from
Mar 26, 2019
Merged

SAMZA-2147: Improve the documentation of the samza release process. #974

merged 2 commits into from
Mar 26, 2019

Conversation

shanthoosh
Copy link
Contributor

Currently the RELEASE.md which outlines the samza release process in open-source has the following problems:

  • There is no clear separation between the steps that has to be followed before and after the successful vote completion.
  • There are formatting errors in the bash commands that has to be executed to validate the release.

This PR fixes the above problems.

@shanthoosh
Copy link
Contributor Author

@dxichen Please take a look when you have a chance.

@shanthoosh
Copy link
Contributor Author

@dxichen
Here is the screen shot of the RELEASE.md file rendered after this patch.
screencapture-file-home-svenkata-Downloads-Samza-Release-Procedure-md-html-2019-03-25-18_03_16

dxichen
dxichen requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@dxichen dxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, thanks for the patch!

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
dxichen
dxichen approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@dxichen dxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shanthoosh
shanthoosh commented Mar 26, 2019
View reviewed changes
Copy link
Contributor Author

@shanthoosh shanthoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
@shanthoosh shanthoosh merged commit a74b500 into apache:master Mar 26, 2019
@shanthoosh shanthoosh deleted the improve_release_md_documentation branch March 26, 2019 01:58
Zhangyx39 pushed a commit to Zhangyx39/samza that referenced this pull request Apr 3, 2019
@shanthoosh @Zhangyx39
SAMZA-2147: Improve the documentation of the samza release process. (a…
e67b4ac 
…pache#974)

* Improve thedocumentation of the samza release process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dxichen dxichen dxichen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shanthoosh @dxichen