Remove call to Signature.getProvider() in debug log #240
+180
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coheigea and @seanjmullan We are unable to upgrade to 3.0.3 or 4.0.0 to get the fix for CVE-2023-44483 because of this issue. Appreciate your attention to this pull request. |
|
Sorry for the delay. I will take a look now. |
seanjmullan
reviewed
Nov 2, 2023
src/main/java/org/apache/xml/security/algorithms/implementations/SignatureBaseRSA.java
Outdated
Show resolved
Hide resolved
The debug log message makes a call to Signature.getProvider() too early. This causes Signature.chooseFirstProvider() to be called which matches the first provider always rather than the correct provider based on PrivateKey.getAlgorithm() when there are multiple providers. This debug log was changed in this commit and introduced the issue: 1f48918 Added unit test cases with fake provider
seanjmullan
approved these changes
Nov 3, 2023
|
Backmerging to 3.0.x as well. |
coheigea
pushed a commit
that referenced
this pull request
Nov 3, 2023
The debug log message makes a call to Signature.getProvider() too early. This causes Signature.chooseFirstProvider() to be called which matches the first provider always rather than the correct provider based on PrivateKey.getAlgorithm() when there are multiple providers. This debug log was changed in this commit and introduced the issue: 1f48918 Added unit test cases with fake provider
coheigea
pushed a commit
that referenced
this pull request
Nov 3, 2023
The debug log message makes a call to Signature.getProvider() too early. This causes Signature.chooseFirstProvider() to be called which matches the first provider always rather than the correct provider based on PrivateKey.getAlgorithm() when there are multiple providers. This debug log was changed in this commit and introduced the issue: 1f48918 Added unit test cases with fake provider
|
@coheigea Is there an ETA for next release ? We are unable to upgrade to latest version to get the CVE fix until this fix included (other than copy-pasting this class into our application to override it) |
|
@narras-oss What release do you specifically need a fix in? |
|
This particular pull request (which is merged) is what I am referring to as the fix, either 3.0.4 or 4.0.1 (next release) would work. |
|
I'm calling a vote on 4.0.1 today with the fix |
|
4.0.1 is in maven central now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug log message makes a call to Signature.getProvider() too early.
This causes Signature.chooseFirstProvider() to be called which matches the first provider always rather than the correct provider based on PrivateKey.getAlgorithm() when there are multiple providers.
This debug log was changed in this commit and introduced the issue: 1f48918
Added unit test cases with fake provider