Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart with new solr command #298

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

skorper
Copy link
Member

@skorper skorper commented Feb 15, 2024

I was running through the quickstart and found the ZK_HOST environment variable wasn't being used by the solr container, resulting in failure. By updating to SDAP_ZK_SERVICE_HOST the solr container ran successfully.

@RKuttruff
Copy link
Contributor

This is odd, my existing deployment with Docker uses ZK_HOST without issue. What kind of error were you seeing?

@skorper
Copy link
Member Author

skorper commented Feb 16, 2024

I can try to recreate the issue a bit later. But in summary, the solr container failed to launch because it could not find the zookeeper host. It seemed like ZK_HOST was being totally ignored. To confirm this, I changed the port in ZK_HOST and noticed the solr container was still attempting to access zookeeper at the old port. When inspecting the solr container I noticed there were other ZK related env vars and played around with it until I found something that worked. I'll post a follow-up with logs and more details soon

@RKuttruff
Copy link
Contributor

Thinking on this, it may be a good idea to provide both commands and inform the user that if one does not work, try the other.

ngachung
ngachung previously approved these changes May 9, 2024
Copy link
Contributor

@ngachung ngachung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this thread https://lists.apache.org/thread/3n2tdsll202z644r4w8x8wb6c0f3o1n0 this change resolved the issue user was encountering, so I think we should merge this.

Copy link
Contributor

@RKuttruff RKuttruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Renewing approval after fixing merge conflict w/ changelog

@RKuttruff RKuttruff merged commit 4a386a5 into apache:develop Jun 10, 2024
RKuttruff added a commit that referenced this pull request Jun 24, 2024
* SDAP-493: Pagination improvements (#282)

* removed resultSizeLimit param from matchup

* Add # of primaries/avergae secondaries to job output

* rename to executionId

* update changelog

* add totalSecondaryMatched field to /job output

* num unique secondaries addition

* updated docs to use correct sea_water_temperature param name

* bugfix

* fix division by zero bug

* SDAP-500: Improvements to SDAP Asynchronous Jobs (#287)

* removed resultSizeLimit param from matchup

* Add # of primaries/avergae secondaries to job output

* rename to executionId

* update changelog

* add totalSecondaryMatched field to /job output

* num unique secondaries addition

* updated docs to use correct sea_water_temperature param name

* bugfix

* fix division by zero bug

* pagination improvements

* removed debugging line

* changelog

* Update helm cassandra dependency (#289)

* Update helm cassandra dependency

* Bump default cassandra PV to 4

* Bump default cassandra PV to 4 in tools

* Changelog

* Fixed small documentation issue

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* update changelog

* rename key to executionID

---------

Co-authored-by: Riley Kuttruff <72955101+RKuttruff@users.noreply.github.com>
Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* SDAP-499: Add page number to default filename for matchup output (#288)

* removed resultSizeLimit param from matchup

* Add # of primaries/avergae secondaries to job output

* rename to executionId

* update changelog

* add totalSecondaryMatched field to /job output

* num unique secondaries addition

* updated docs to use correct sea_water_temperature param name

* bugfix

* fix division by zero bug

* add page number to default filename for matchup output

* pagination improvements

* removed debugging line

* changelog

* Update helm cassandra dependency (#289)

* Update helm cassandra dependency

* Bump default cassandra PV to 4

* Bump default cassandra PV to 4 in tools

* Changelog

* Fixed small documentation issue

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* Revert "Update helm cassandra dependency (#289)"

This reverts commit 1e8cc4e.

* changelog

---------

Co-authored-by: Riley Kuttruff <72955101+RKuttruff@users.noreply.github.com>
Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* SDAP-506: STAC Catalog for Matchup outputs (#291)

* removed resultSizeLimit param from matchup

* Add # of primaries/avergae secondaries to job output

* rename to executionId

* update changelog

* add totalSecondaryMatched field to /job output

* num unique secondaries addition

* updated docs to use correct sea_water_temperature param name

* bugfix

* fix division by zero bug

* add page number to default filename for matchup output

* pagination improvements

* removed debugging line

* changelog

* Update helm cassandra dependency (#289)

* Update helm cassandra dependency

* Bump default cassandra PV to 4

* Bump default cassandra PV to 4 in tools

* Changelog

* Fixed small documentation issue

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* stac catalog

* Updated openapi spec

* move stac endpoints to matchup tag in openapi spec

* Revert "Update helm cassandra dependency (#289)"

This reverts commit 1e8cc4e.

* fix bug where still-running jobs failed /job endpoint due to missing metadata

* Update .asf.yaml (#293)

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* update changelog

* re-add removed changelog entry

---------

Co-authored-by: Riley Kuttruff <72955101+RKuttruff@users.noreply.github.com>
Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* SDAP-508 report sat spatial extents (#295)

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* SDAP-505: Support DOMS insitu API (#299)

* support DOMS insitu API

* update NCAR insitu url

* add endpoint for getting insitu units

* SDAP-472 - data-access overhaul to support multiple simultaneous data backends (#294)

* Separated NTS backends

* n/a

* More nts backend stuff

* Working(?) np backend

* Working(?) np backend

* gitignore ini

* ASF headers

* First functioning test of 2 simultaneous backends

* Removed accidentally committed ini files

* Working zarr backend ds list

+ datasets are no longer case sensitive
+ handling for failed zarr ds opens (bad path, bad creds, &c)

* Capture and handle NTS requests routed to backend that doesn't (yet) support them

* analysis setup fails to find VERSION.txt when building locally

* Implemented more NTS functions in zarr backend

* Added misc backend time metrics record field in NCSH

* fixes

* Dynamic dataset management

* Dynamic dataset management

* Dataset management

* Timeseriesspark support

* Update backend dict on dataset mgmt query

* Fixes and improvements

* Adapted matchup to work with zarr backends

* Zarr support

- Distinct slices of time is now default
- No longer assuming+shaping as multivar tiles unless needed

* DDAS adjustments

* find_tile_by_polygon_and_most_recent_day_of_year impl

* Don't sel by time if neither max nor min time are given

* Fix not calling partial when needed

* Pinned s3fs and fsspec versions

* Fixed some dependencies to ensure image builds properly + s3fs works

* Config override for backends

* Deps update

* Add metadata from Zarr collection to /list

* Zarr: Probe lat order and flip if necessary

* Strip quotes from variable names

CM can sometimes publish with extra quotes resulting in KeyErrors

* removed resultSizeLimit param from matchup

* Add # of primaries/avergae secondaries to job output

* rename to executionId

* update changelog

* add totalSecondaryMatched field to /job output

* num unique secondaries addition

* updated docs to use correct sea_water_temperature param name

* bugfix

* fix division by zero bug

* add params to dataset management handler classes

* add page number to default filename for matchup output

* pagination improvements

* removed debugging line

* changelog

* Update helm cassandra dependency (#289)

* Update helm cassandra dependency

* Bump default cassandra PV to 4

* Bump default cassandra PV to 4 in tools

* Changelog

* Fixed small documentation issue

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* stac catalog

* Updated openapi spec

* move stac endpoints to matchup tag in openapi spec

* SDAP-507 - Changes to remove geos sub-dependency

* SDAP-507 - Changelog

* SDAP-507 - Changes to remove geos sub-dependency

* SDAP-507 - Changelog

* delete instead of comment out

* Revert "Update helm cassandra dependency (#289)"

This reverts commit 1e8cc4e.

* deleted disabled endpoint files

* fix bug where still-running jobs failed /job endpoint due to missing metadata

* Update .asf.yaml (#293)

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* Moved changelog entries

* SDAP-472 changelog entries

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>
Co-authored-by: skorper <stepheny.k.perez@gmail.com>

* Merge master into develop post-1.2.0 release (#305)

* Update .asf.yaml (#293)

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* domspurge patch (#280)

* Fix delete query to account for PK update

* Fixed mistake in domspurge readme

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* Patch: Made conda dep changes accidentally omitted from geos PR

* SDAP-511 - Switch package manager to poetry (#301)

* Redid branch w/ correct base

I tried to just rebase but it didn't work properly

* Changelogs

* Delete old dockerfile

* Removed old conda install files

* Removed version.txt to just use pyproject.toml

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* pyproject.toml dependency updates for Zarr

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>
Co-authored-by: Stepheny Perez <skorper@users.noreply.github.com>

* SDAP 515 - Improved handling of unreachable remote SDAPs (#308)

* Improved error handling to account for any reason a remote is not reachable

* Further fixes for unreachable remote SDAPs

* Improved logging

* SDAP-513 - Configurable Solr init pod image in helm (#306)

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* Added some missing ASF headers and removed some unneeded files (#302)

* Remove IDE files

* Added more missing headers

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* Update requirements.txt (#309)

* Updates to openapi (#310)

* Disable the try it now button

* Added additional spark algorithms

* Updates to openapi to include additional algorithms

* SDAP-518 - Collection Config Docs (#311)

* Initial work on CC docs

* Add collections to index toctree

* YAML highlighting

* NetCDF section

* remove incubation msg from intro.rst

* Added recs for gridded tile size

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* data-access patch (#313)

* Patches to backend mgmt and zarr backend

- Code cleanup
- Added dask as dependency, so it will be leveraged with Zarr datasets
- Fixed creation of tile times array from Zarr data to ensure its in seconds from 1970-01-01. Original method has been seen to produce incorrect results from bad assumptions

* Changelog

---------

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* Changed SDAP startup behavior to wait for all datasets to be prepared before accepting HTTP requests (#314)

Co-authored-by: rileykk <rileykk@jpl.nasa.gov>

* update quickstart with updated solr command (#298)

Co-authored-by: Riley Kuttruff <72955101+RKuttruff@users.noreply.github.com>

* Update release files

- 1.3.0 header in changelogs
- Removed incubation DISCLAIMER
- Removed incubation language from NOTICE and updated URLs
- Bumped versions
- Made copyright year current
- Poetry re-lock

* Fix Dockerfile for DISCLAIMER rm

---------

Co-authored-by: Stepheny Perez <skorper@users.noreply.github.com>
Co-authored-by: rileykk <rileykk@jpl.nasa.gov>
Co-authored-by: skorper <stepheny.k.perez@gmail.com>
Co-authored-by: Kevin <kevinmarlis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants