Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][build] root's pom.xml don't need to manage all dependencies #2606

Closed
2 of 3 tasks
Tracked by #2604
ashulin opened this issue Sep 2, 2022 · 2 comments · Fixed by #2613, #2623, #2630 or #2686
Closed
2 of 3 tasks
Tracked by #2604

[Improve][build] root's pom.xml don't need to manage all dependencies #2606

ashulin opened this issue Sep 2, 2022 · 2 comments · Fixed by #2613, #2623, #2630 or #2686
Assignees

Comments

@ashulin
Copy link
Member

ashulin commented Sep 2, 2022

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

In the future, we will support multiple versions of the flink/spark engine, and version management will become an important issue.

seatunnel manages all dependencies in root's pom.xml, while many connectors require different versions of dependencies;
I expect to only manage basic core dependencies such as log4j, commons in root's pom.xml;
The dependencies of connectors and engines are managed by their modules;

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ashulin ashulin assigned ashulin and CalvinKirs and unassigned ashulin Sep 2, 2022
@ashulin ashulin linked a pull request Sep 2, 2022 that will close this issue
@ashulin ashulin linked a pull request Sep 3, 2022 that will close this issue
Hisoka-X pushed a commit that referenced this issue Sep 5, 2022
* [#2606]Dependency management split
#2606 subtask

* set seatunnel-api scope to provide

* add seatunnel-api dependency
@liugddx
Copy link
Member

liugddx commented Sep 5, 2022

e2e test need jdbc driver,Is it a direct dependency now? or add bom model?

@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 6, 2022

@liugddx We will support add driver into e2e, track this: #2640

MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this issue Sep 8, 2022
* [apache#2606]Dependency management split
apache#2606 subtask

* set seatunnel-api scope to provide

* add seatunnel-api dependency
laglangyue pushed a commit to laglangyue/seatunnel that referenced this issue Sep 11, 2022
* [apache#2606]Dependency management split
apache#2606 subtask

* set seatunnel-api scope to provide

* add seatunnel-api dependency
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this issue Sep 15, 2022
* [apache#2606]Dependency management split
apache#2606 subtask

* set seatunnel-api scope to provide

* add seatunnel-api dependency
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this issue Sep 16, 2022
* [apache#2606]Dependency management split
apache#2606 subtask

* set seatunnel-api scope to provide

* add seatunnel-api dependency
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this issue Sep 18, 2022
* [apache#2606]Dependency management split
apache#2606 subtask

* set seatunnel-api scope to provide

* add seatunnel-api dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment