Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] when upgrade 2.3.5 version from 2.3.4, job restore failed #6853

Closed
2 of 3 tasks
liunaijie opened this issue May 14, 2024 · 4 comments · Fixed by #7001
Closed
2 of 3 tasks

[Bug] when upgrade 2.3.5 version from 2.3.4, job restore failed #6853

liunaijie opened this issue May 14, 2024 · 4 comments · Fixed by #7001
Labels
bug stale

Comments

@liunaijie
Copy link
Contributor

liunaijie commented May 14, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

In version 2.3.4, i enable the IMAP storage cache, when upgrade to version 2.3.5. Will get exception when read data from the cached imap data.
the error reason is this pr https://github.com/apache/seatunnel/pull/6666/files#r1598217272 update the field type in IMAP cached class.

SeaTunnel Version

2.3.5

SeaTunnel Config

na

Running Command

na

Error Exception

image

Zeta or Flink or Spark Version

zeta

Java or Scala Version

No response

Screenshots

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@liunaijie liunaijie added the bug label May 14, 2024
@liunaijie liunaijie mentioned this issue May 15, 2024
Merged
4 tasks
@Hisoka-X
Copy link
Member

cc @EricJoy2048

@liunaijie
Copy link
Contributor Author

For the storage info (imap, checkpoint), In feature maybe still has some change, like add a filed, data type change.
We need make sure we can compatible with old version (at least last version), then we can restore the historary data.

What can we do now:

  1. fix in release version or give advice (soluaction/warning) to user that want upgrade to version 2.3.5
  2. add ut to make sure in feature when we modify those class, we can notice this case.

@Hisoka-X
Copy link
Member

add ut to make sure in feature when we modify those class, we can notice this case.

Yes, this is one I really think SeaTunnel should have.

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Jun 15, 2024
@liunaijie liunaijie mentioned this issue Jun 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] revert IMAP cache data field type to compatible with old version liunaijie/seatunnel
2 participants
@liunaijie @Hisoka-X