Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] revert IMAP cache data field type to compatible with old version #7001

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

liunaijie
Copy link
Contributor

Purpose of this pull request

fix #6853

Does this PR introduce any user-facing change?

How was this patch tested?

using exist test.

we need conside how to test the version compatible.

now we can't save binary file to github, so we can't read from binary file to check whether compatible with current. and we can't gererate the old version cache data from current version.

now just revert the code.

Check list

@liunaijie liunaijie marked this pull request as ready for review June 17, 2024 10:21
@Hisoka-X
Copy link
Member

now we can't save binary file to github, so we can't read from binary file to check whether compatible with current. and we can't gererate the old version cache data from current version.

We can use old version jar to submit job then get binary file. Then use new version jar to submit job and read binary file. It's all in docker. So I think it should be worked.

@Hisoka-X Hisoka-X added the bug label Jun 18, 2024
@Hisoka-X Hisoka-X added this to the 2.3.6 milestone Jun 19, 2024
@liunaijie
Copy link
Contributor Author

if we fix it in version 2.3.6 , it still has issue when upgrade from 2.3.5. but it's ok for older version like 2.3.4.
if we not fix it, it will be ok when upgrade from 2.3.5. but will has issue when from version before 2.3.4

@Hisoka-X
Copy link
Member

if we fix it in version 2.3.6 , it still has issue when upgrade from 2.3.5. but it's ok for older version like 2.3.4. if we not fix it, it will be ok when upgrade from 2.3.5. but will has issue when from version before 2.3.4

Yes, we should fix it before release 2.3.6. Could you create an issue about add test case for imap upgrade?

@Hisoka-X
Copy link
Member

if we fix it in version 2.3.6 , it still has issue when upgrade from 2.3.5. but it's ok for older version like 2.3.4. if we not fix it, it will be ok when upgrade from 2.3.5. but will has issue when from version before 2.3.4

Yes, we should fix it before release 2.3.6. Could you create an issue about add test case for imap upgrade?

Added #7055

@Hisoka-X Hisoka-X merged commit 165bfae into apache:dev Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] when upgrade 2.3.5 version from 2.3.4, job restore failed
3 participants