Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Transform] data quality for null data rate #1978

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

wsyhj
Copy link
Contributor

@wsyhj wsyhj commented May 31, 2022

Purpose of this pull request

#1977(#1977)

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Jun 3, 2022

Please solve compile problem first

@wsyhj
Copy link
Contributor Author

wsyhj commented Jun 6, 2022

Please solve compile problem first

The error is ‘Can't use 'tar -xzf'’ ,so how to solve

@Hisoka-X
Copy link
Member

Hisoka-X commented Jun 6, 2022

Please solve compile problem first

The error is ‘Can't use 'tar -xzf'’ ,so how to solve

I rerun it, seem like already pass

@@ -0,0 +1,67 @@
# EncryptedPhone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header wrong




### field [string]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be string_list


Which fields do you want to monitor .

### rates [double]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be double_list

object NullRateConfig {
val FIELDS = "fields"
val RATES = "rates"
val IS_THROWEXCEPTION = "throwException_enable"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throwException_enable should be throw_exception_enable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done all

.add("setting_rate", DataTypes.LongType)
.add("null_rate", DataTypes.LongType)
.add("rate_percent", DataTypes.LongType)
env.getSparkSession.createDataset(nullRateRows)(RowEncoder(schema)).createOrReplaceTempView(config.getString(Plugin.RESULT_TABLE_NAME))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RESULT_TABLE_NAME shouldn't use in here, SeaTunnel will auto create temp view for Dataset which return by this method, and named RESULT_TABLE_NAME, so other plugin can drectly use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Hisoka-X Hisoka-X added the Waiting for users feedback Waiting for feedback from issue/PR author label Jun 7, 2022
@Hisoka-X Hisoka-X merged commit 990ee89 into apache:dev Jun 23, 2022
@CalvinKirs CalvinKirs added this to the 2.1.3 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss First-time contributor First-time contributor transform Waiting for users feedback Waiting for feedback from issue/PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants