Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector] add IT for Assert Sink in e2e module #2036

Merged
merged 7 commits into from
Jul 1, 2022

Conversation

lhyundeadsoul
Copy link
Contributor

Purpose of this pull request

add IT to test Assert Sink plugin
#2034

Check list

@lhyundeadsoul
Copy link
Contributor Author

PTAL @ruanwenjun Thx!

@Hisoka-X Hisoka-X requested a review from ruanwenjun June 23, 2022 08:21
Hisoka-X
Hisoka-X previously approved these changes Jun 23, 2022
@ruanwenjun
Copy link
Member

@lhyundeadsoul Is there any count rule? e.g. I want to assert the batch row count is 4.

@lhyundeadsoul
Copy link
Contributor Author

@lhyundeadsoul Is there any count rule? e.g. I want to assert the batch row count is 4.
Thanks for your idea.
I support five assert rule now: min/max/min_length/max_length/not null , and will consider count rule in another PR.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun
Copy link
Member

The IT failed.

amend assert config to fit FakeSource config
@ruanwenjun
Copy link
Member

Could you please make the ci pass.

@lhyundeadsoul
Copy link
Contributor Author

lhyundeadsoul commented Jun 30, 2022

Both console and assert e2e IT failed.
org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

@Hisoka-X
Copy link
Member

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

In your local?

@lhyundeadsoul
Copy link
Contributor Author

lhyundeadsoul commented Jun 30, 2022

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

In your local?

Maybe it's in my local.

I find the root cause : There is no org.apache.seatunnel.core.flink.FlinkEnvParameterParser in my target jar but it source code does exists.
an error often occur while execute 'mvn install', I think this is the root cause.

Failure to find org.apache.seatunnel:seatunnel:pom:${revision} in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Have you ever had this?

@Hisoka-X
Copy link
Member

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

In your local?
Maybe it's in my local.

I find the root cause : There is no org.apache.seatunnel.core.flink.FlinkEnvParameterParser in my target jar. and an error often occur while execute 'mvn install'

Failure to find org.apache.seatunnel:seatunnel:pom:${revision} in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Have you ever had this?

Yes, also confusion me😭

@lhyundeadsoul
Copy link
Contributor Author

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

In your local?
Maybe it's in my local.

I find the root cause : There is no org.apache.seatunnel.core.flink.FlinkEnvParameterParser in my target jar. and an error often occur while execute 'mvn install'

Failure to find org.apache.seatunnel:seatunnel:pom:${revision} in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Have you ever had this?

Yes, also confusion me😭

Wow~ I am not the only one~
HELP! @ruanwenjun Have you ever had this error?

@Hisoka-X
Copy link
Member

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

In your local?
Maybe it's in my local.

I find the root cause : There is no org.apache.seatunnel.core.flink.FlinkEnvParameterParser in my target jar. and an error often occur while execute 'mvn install'

Failure to find org.apache.seatunnel:seatunnel:pom:${revision} in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Have you ever had this?

Yes, also confusion me😭

Wow~ I am not the only one~ HELP! @ruanwenjun Have you ever had this error?

I doubt it is caused by flatten-maven-plugin. But I don't have test.

@lhyundeadsoul
Copy link
Contributor Author

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

In your local?
Maybe it's in my local.

I find the root cause : There is no org.apache.seatunnel.core.flink.FlinkEnvParameterParser in my target jar. and an error often occur while execute 'mvn install'

Failure to find org.apache.seatunnel:seatunnel:pom:${revision} in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Have you ever had this?

Yes, also confusion me😭

Wow~ I am not the only one~ HELP! @ruanwenjun Have you ever had this error?

I doubt it is caused by flatten-maven-plugin. But I don't have test.

Maybe. Sometimes it work, sometimes it fail. Occur randomly.

@Hisoka-X
Copy link
Member

Maybe. Sometimes it work, sometimes it fail. Occur randomly.

if you package success local, everything will be fine.

@Hisoka-X
Copy link
Member

Both console and assert e2e IT failed. org.apache.seatunnel.e2e.flink.fake.FakeSourceToConsoleIT

22/06/30 17:18:28 ERROR FlinkContainer: Error: Could not find or load main class org.apache.seatunnel.core.flink.FlinkEnvParameterParser


java.lang.AssertionError: 
Expected :0
Actual   :1
<Click to see difference>

So this error have any progress?

@lhyundeadsoul
Copy link
Contributor Author

lhyundeadsoul commented Jun 30, 2022

a new error occur after package successfully.

Caused by: java.lang.RuntimeException: No data sinks have been created yet. A program needs at least one sink that consumes data. Examples are writing the data set or printing it.
	at org.apache.flink.api.java.ExecutionEnvironment.createProgramPlan(ExecutionEnvironment.java:1170)
	at org.apache.flink.api.java.ExecutionEnvironment.getExecutionPlan(ExecutionEnvironment.java:1076)
	at org.apache.seatunnel.flink.batch.FlinkBatchExecution.start(FlinkBatchExecution.java:76)
	at org.apache.seatunnel.core.flink.command.FlinkTaskExecuteCommand.execute(FlinkTaskExecuteCommand.java:81)
	... 15 more

I working on it

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhyundeadsoul
Copy link
Contributor Author

@Hisoka-X PTAL

@Hisoka-X Hisoka-X merged commit cd1241d into apache:dev Jul 1, 2022
@lhyundeadsoul lhyundeadsoul deleted the assert-e2e branch July 1, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants