Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][connector]Fix the bug Unrecognized field "TwoPhaseCommit" after doris 0.15 #2054

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

smallhibiscus
Copy link
Contributor

Purpose of this pull request

Fix the bug Unrecognized field "TwoPhaseCommit" after doris 0.15

Caused by: java.lang.RuntimeException: org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "TwoPhaseCommit" (class org.apache.seatunnel.flink.doris.sink.RespContent), not marked as ignorable (18 known properties: "CommitAndPublishTimeMs", "ExistingJobStatus", "TxnId", "twoPhaseCommit", "Message", "Status", "ReadDataTimeMs", "Label", "NumberUnselectedRows", "NumberFilteredRows", "StreamLoadPutTimeMs", "LoadBytes", "NumberLoadedRows", "NumberTotalRows", "LoadTimeMs", "WriteDataTimeMs", "BeginTxnTimeMs", "ErrorURL"]) at [Source: (String)"{ "TxnId": 9, "Label": "flink_sink_20220623_160111_5c25cc6270f241b69b64726b204e5538", "TwoPhaseCommit": "false", "Status": "Success", "Message": "OK", "NumberTotalRows": 2, "NumberLoadedRows": 2, "NumberFilteredRows": 0, "NumberUnselectedRows": 0, "LoadBytes": 392, "LoadTimeMs": 37, "BeginTxnTimeMs": 0, "StreamLoadPutTimeMs": 2, "ReadDataTimeMs": 0, "WriteDataTimeMs": 14, "CommitAndPublishTimeMs": 19}"; line: 1, column: 115] (through reference chain: org.apache.seatunnel.flink.doris.sink.RespContent["TwoPhaseCommit"])

Check list

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but I think it's better for rsp we only care about the main few fields like status. The other fields don't make much sense, at least for now. I would prefer the content of Rsp to be simple rather than overly concerned, maybe you need to modify the json tool so that it ignores some fields (only converts the fields we declare)

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 418e408 into apache:dev Jul 4, 2022
@CalvinKirs CalvinKirs added this to the 2.1.3 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants