[Bug] [seatunnel-core] Failed to get APP_DIR path bug fixed #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
3 tasks
Hisoka-X
pushed a commit
that referenced
this pull request
Jul 26, 2022
* [Bug] [seatunnel-core] Failed to get APP_DIR path bug fixed (#2165) [Core][Starter] When use cluster mode, but starter app root dir also should same as client mode. (#2141) [bug]fix commandArgs -t(--check) conflict with flink deployment t… (#2174) [Core][Starter] Change jar connector load logic (#2193) [Core]Add plugin discovery module (#1881) Upgrade common-collecions4 to 4.4 Upgrade common-codec to 1.13 * add plugin discover module * Add SeaTunnel API module * fix license check error * ignore 403 deadlink check * move plugin-mapping.properties to root path * Revert "move plugin-mapping.properties to root path" This reverts commit 372968e. * add fake-stream config Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to get APP_DIR path when using Nested "$" in this shell scripts occasionally
The shell scripts are：
"start-seatunnel-flink.sh"
"start-seatunnel-flink-new-connector.sh"
"start-seatunnel-spark.sh"
"start-seatunnel-spark-new-connector.sh"
"start-seatunnel-sql.sh"
this line: "APP_DIR=(dirname ${0})/../;pwd) " causing Failed to get APP_DIR path has bug.
Feel free to ping committers for the review!
Contribution Checklist
Make sure that the pull request corresponds to a GITHUB issue.
Name the pull request in the form "[Feature] [component] Title of the pull request", where Feature can be replaced by
Hotfix,Bug, etc.Minor fixes should be named following this pattern:
[hotfix] [docs] Fix typo in README.md doc.-->
Purpose of this pull request
Check list
New License Guide