Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-Achieved Redis Proxy which is not support redis function of "info replication" #2389

Merged
merged 9 commits into from
Aug 16, 2022
Merged

Self-Achieved Redis Proxy which is not support redis function of "info replication" #2389

merged 9 commits into from
Aug 16, 2022

Conversation

chocolateBlack
Copy link
Contributor

@chocolateBlack chocolateBlack commented Aug 9, 2022 •
edited

#2150

Purpose of this pull request

Check list

@CalvinKirs CalvinKirs added improve connectors-v1 SeaTunnel connectors, include sink, source labels Aug 10, 2022
wuchunfu
wuchunfu reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chocolateBlack Please add license header, thx.

@chocolateBlack
Copy link
Contributor Author

chocolateBlack commented Aug 10, 2022 •
edited

@chocolateBlack Please add license header, thx.
@wuchunfu licence header is added , is that ok? please do me a favor to check it
@wuchunfu please approve running workflows, thanks a lot

@wuchunfu
Copy link
Member

@chocolateBlack Please update the relevant documentation, thanks.

wuchunfu
wuchunfu approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 45c542c into apache:dev Aug 16, 2022
@CalvinKirs
Copy link
Member

Could you check connector-v2? does it have this feature?

@chocolateBlack
Copy link
Contributor Author

Could you check connector-v2? does it have this feature?

@CalvinKirs There is no Redis Sink in connector-v2.
what's the different between v1 and v2. Is there any docs for us to learn the purpose and details of v2.

TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@chocolateBlack @TyrantLucifer
[Connector-v1]Self-Achieved Redis Proxy which is not support redis fu…
bfcc2bf 
…nction of "info replication" (apache#2389)

* self achieved redis proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuchunfu wuchunfu Awaiting requested review from wuchunfu

Assignees
No one assigned
Labels
connectors-v1 SeaTunnel connectors, include sink, source improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chocolateBlack @wuchunfu @CalvinKirs