[Feature][Connector-V2] Add Enterprise Wechat sink connector #2412

531651225 · 2022-08-14T23:36:26Z

#1946 Add Enterprise WeChart source base on HttpSink

Purpose of this pull request

Check list

Code changed are covered with tests, or it does not need tests for reason:
If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

This reverts commit b60060d.

ashulin · 2022-08-15T02:18:22Z

docs/en/connector-v2/sink/Enterprise-WeChart.md

+
+A sink plugin which use Enterprise WeChart robot send message
+
+##  Options


Missing description of other options, such as common options in http connector

Missing description of other options, such as common options in http connector

I have added description of other options，detail in new commit

TyrantLucifer · 2022-08-15T02:17:02Z

...p-wechat/src/main/java/org/apache/seatunnel/connectors/seatunnel/wechat/sink/WeChatSink.java

+    private final String webHookUrl = "url";
+
+    @Override
+    public void prepare(Config pluginConfig) throws PrepareFailException {


This overwrite method is useless, because httpSink had checked the parameter url.

this method use to construct httpParameter which WeChatHttpSinkWriter constructor needed.
WeChatHttpSinkWriter redefind a SeaTunnelRowType for WeChat send content in constructor.

In my option, you can change httpParameter that in connector-http-base from private to protected.

In my option, you can change httpParameter that in connector-http-base from private to protected.

Thx,i will try .this way is more convenient.

CalvinKirs

If it is simply outputting the result without any formatting, then the sink is of little significance. For this kind of connector, what the user needs to see is a formatted result.

… info

531651225 · 2022-08-16T06:21:33Z

If it is simply outputting the result without any formatting, then the sink is of little significance. For this kind of connector, what the user needs to see is a formatted result.

I have added a Commonly used output format ，detail in doc.

531651225 · 2022-08-16T06:39:30Z

If it is simply outputting the result without any formatting, then the sink is of little significance. For this kind of connector, what the user needs to see is a formatted result.

I have added a Commonly used output format ，detail in doc.

new output format in wethat actual display like this

EricJoy2048 · 2022-08-16T07:15:21Z

docs/en/connector-v2/sink/Enterprise-WeChat.md

+## Description
+
+A sink plugin which use Enterprise WeChat robot send message
+> For example, if the data from upstream is [`"告警状态": "firing", "告警时间": "2022-08-03 01:38:49"，"告警内容": "磁盘使用超出阈值"`], the output content to WeChat Robot is the following:


I suggest you change the chinese to english.

I suggest you change the chinese to english.

Thx,i have changed in new committ

EricJoy2048 · 2022-08-16T07:22:47Z

...rc/main/java/org/apache/seatunnel/connectors/seatunnel/wechat/sink/WeChatHttpSinkWriter.java

+        }
+        HashMap<Object, Object> objectMap = new HashMap<>();
+        objectMap.put(WeChatSinkConfig.WECHAT_SEND_MSG_CONTENT_KEY, stringBuffer.toString());
+        if (!weChatSinkConfig.getMentionedMobileList().isEmpty()) {


getMentionedMobileList() may return null value here. So I suggest you use CollectionUtils.isEmpty here.

Thx,i have changed in new committ

getMentionedMobileList() may return null value here. So I suggest you use CollectionUtils.isEmpty here.

Thx,i have changed in new committ

…incubator-seatunnel into wechat-connector-sink

EricJoy2048

+1

531651225 · 2022-08-17T01:31:40Z

+1

fix code checkstyle problem，can you help me review or approve

CalvinKirs · 2022-08-17T01:46:33Z

AFAIK, There are other things that enterprise WeChat can do, and it will be better if you can improve it. Looking forward to your optimization PR.
There are other things that enterprise WeChat can do, and it will be better if you can improve it. Looking forward to your optimization PR.

531651225 · 2022-08-17T01:56:14Z

AFAIK, There are other things that enterprise WeChat can do, and it will be better if you can improve it. Looking forward to your optimization PR. There are other things that enterprise WeChat can do, and it will be better if you can improve it. Looking forward to your optimization PR.

Thx,I will try to do it.

…#2412) * [Feature][Connector-V2] Add Enterprise WeChart source output format

毕博 added 6 commits August 13, 2022 18:32

[Feature][Connector-V2] Add Enterprise WeChart source

b60060d

Revert "[Feature][Connector-V2] Add Enterprise WeChart source"

44bbdc8

This reverts commit b60060d.

[Feature][Connector-V2] Add Enterprise WeChart source base on HttpSink

5ddfcd4

[Feature][Connector-V2] Add Enterprise WeChart source base on HttpSink

d5f4836

[Feature][Connector-V2] Add Enterprise WeChart source base on HttpSink

1feff4f

[Feature][Connector-V2] Add Enterprise WeChart source base on HttpSink

2ef999c

531651225 changed the title ~~Wechat connector sink~~ [Feature][Connector-V2] Wechat connector sink Aug 15, 2022

531651225 changed the title ~~[Feature][Connector-V2] Wechat connector sink~~ [Feature][Connector-V2] Add Enterprise Wechat sink connector Aug 15, 2022

ashulin reviewed Aug 15, 2022

View reviewed changes

TyrantLucifer reviewed Aug 15, 2022

View reviewed changes

CalvinKirs requested changes Aug 15, 2022

View reviewed changes

TyrantLucifer mentioned this pull request Aug 15, 2022

[Improve][Connector-V2] Improve http connector #2418

Merged

3 tasks

毕博 added 3 commits August 16, 2022 13:57

Merge branch 'dev' into wechat-connector-sink

162429c

[Feature][Connector-V2] Add Enterprise WeChart source output format

08f25e5

[Feature][Connector-V2] add Enterprise WeChart source doc more config…

3e4f89b

… info

Merge branch 'apache:dev' into wechat-connector-sink

ca0e49b

EricJoy2048 requested changes Aug 16, 2022

View reviewed changes

毕博 and others added 4 commits August 16, 2022 15:42

[Feature][Connector-V2] add Enterprise WeChart source more info

7a282dc

Merge branch 'apache:dev' into wechat-connector-sink

0d61b03

Merge branch 'dev' into wechat-connector-sink

cc3ac05

Merge branch 'wechat-connector-sink' of https://github.com/531651225/…

f48d03d

…incubator-seatunnel into wechat-connector-sink

531651225 requested a review from EricJoy2048 August 16, 2022 08:30

EricJoy2048 previously approved these changes Aug 16, 2022

View reviewed changes

531651225 requested a review from CalvinKirs August 16, 2022 09:48

[Feature][Connector-V2] add Enterprise WeChart fix code checkstyle fail

7eeb144

531651225 dismissed EricJoy2048’s stale review via 7eeb144 August 16, 2022 11:19

531651225 requested a review from EricJoy2048 August 16, 2022 11:26

CalvinKirs approved these changes Aug 17, 2022

View reviewed changes

CalvinKirs merged commit 3e200e0 into apache:dev Aug 17, 2022

CalvinKirs added the connectors-v2 label Aug 17, 2022

531651225 mentioned this pull request Aug 19, 2022

[Umbrella][Connector] New SeaTunnel API Connectors #1946

Closed

TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022

[Feature][Connector-V2] Add Enterprise Wechat sink connector (apache…

8016816

…#2412) * [Feature][Connector-V2] Add Enterprise WeChart source output format

EricJoy2048 mentioned this pull request Oct 8, 2022

[Umbrella][Connector-V2] SeaTunnel Connector V2 Tracking Table #3018

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature][Connector-V2] Add Enterprise Wechat sink connector #2412

[Feature][Connector-V2] Add Enterprise Wechat sink connector #2412

531651225 commented Aug 14, 2022

ashulin Aug 15, 2022

531651225 Aug 16, 2022

TyrantLucifer Aug 15, 2022

531651225 Aug 15, 2022

TyrantLucifer Aug 15, 2022

531651225 Aug 15, 2022

CalvinKirs left a comment

531651225 commented Aug 16, 2022

531651225 commented Aug 16, 2022

EricJoy2048 Aug 16, 2022

531651225 Aug 16, 2022

EricJoy2048 Aug 16, 2022

531651225 Aug 16, 2022

531651225 Aug 16, 2022

EricJoy2048 left a comment

531651225 commented Aug 17, 2022

CalvinKirs commented Aug 17, 2022

531651225 commented Aug 17, 2022


		A sink plugin which use Enterprise WeChart robot send message

		## Options

[Feature][Connector-V2] Add Enterprise Wechat sink connector #2412

[Feature][Connector-V2] Add Enterprise Wechat sink connector #2412

Conversation

531651225 commented Aug 14, 2022

Purpose of this pull request

Check list

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CalvinKirs left a comment

Choose a reason for hiding this comment

531651225 commented Aug 16, 2022

531651225 commented Aug 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EricJoy2048 left a comment

Choose a reason for hiding this comment

531651225 commented Aug 17, 2022

CalvinKirs commented Aug 17, 2022

531651225 commented Aug 17, 2022