[Connectors-V2]Support IoTDB Source #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e2e sink already done. i will add it after sink merged |
hailin0
reviewed
Aug 17, 2022
hailin0
reviewed
Aug 17, 2022
hailin0
reviewed
Aug 17, 2022
hailin0
reviewed
Aug 17, 2022
...iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/config/SourceConfig.java
Outdated
Show resolved
Hide resolved
hailin0
reviewed
Aug 17, 2022
...-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java
Outdated
Show resolved
Hide resolved
hailin0
reviewed
Aug 17, 2022
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSourceReader.java
Outdated
Show resolved
Hide resolved
hailin0
reviewed
Aug 17, 2022
.../java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSourceSplitEnumerator.java
Show resolved
Hide resolved
# Conflicts: # plugin-mapping.properties # seatunnel-connectors-v2/connector-iotdb/pom.xml
# Conflicts: # plugin-mapping.properties # seatunnel-connectors-v2/connector-iotdb/pom.xml
|
@hailin0 hi, PTAL again.thx |
hailin0
reviewed
Aug 18, 2022
| throw new PrepareFailException(getPluginName(), PluginType.SOURCE, "host and port and node urls are both empty"); | ||
| } | ||
| } | ||
| SeatunnelSchema seatunnelSchema = SeatunnelSchema.buildWithConfig(pluginConfig); |
There was a problem hiding this comment.
Define like this?
schema { fields { code = int data = string success = boolean } }
Using a unified format will facilitate future merged schema into connector api
There was a problem hiding this comment.
There was a problem hiding this comment.
hi, as it stands, it probably doesn't make much sense to use an extra level of nesting. What is the meaning of schema and field?
|
LGTM |
Hisoka-X
approved these changes
Aug 19, 2022
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
* [Connectors-V2]Support IoTDB Source * fix license header * fix java doc * fix check style * improve read method * used by SeatunelSchema get source field type * fetch upstream * reformat docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.