[Improve][Connector-V2] Pulsar support user-defined schema #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ashulin
force-pushed
the
hotfix/pulsar-row-type
branch
from
f92415a
to
69dcea1
Compare
hailin0
reviewed
Aug 21, 2022
| @@ -222,7 +225,9 @@ private void setPartitionDiscoverer(Config config) { | |||
|
|
|||
| private void setDeserialization(Config config) { | |||
| String format = config.getString("format"); | |||
| // TODO: json format | |||
| // TODO: format SPI | |||
| SeaTunnelRowType rowType = SeatunnelSchema.buildWithConfig(config.getConfig(SeatunnelSchema.SCHEMA)).getSeaTunnelRowType(); | |||
There was a problem hiding this comment.
Use fields as config key? reference #2469
example:
SeaTunnelRowType rowType = SeatunnelSchema.buildWithConfig(config).getSeaTunnelRowType();There was a problem hiding this comment.
SeatunnelSchema does not support your notation yet;
There was a problem hiding this comment.
There was a problem hiding this comment.
You can merge from dev again. Then you can use this feature.
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Aug 30, 2022
* [Improve][Connector-V2] Pulsar support user-defined schema * import the constant
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 8, 2022
* [Improve][Connector-V2] Pulsar support user-defined schema * import the constant
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 15, 2022
* [Improve][Connector-V2] Pulsar support user-defined schema * import the constant
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 16, 2022
* [Improve][Connector-V2] Pulsar support user-defined schema * import the constant
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
* [Improve][Connector-V2] Pulsar support user-defined schema * import the constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide