Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] Add mongodb connecter source #2596

Merged
merged 16 commits into from
Sep 7, 2022
Merged

[Feature][Connector-V2] Add mongodb connecter source #2596

merged 16 commits into from
Sep 7, 2022

Conversation

wuchunfu
Copy link
Member

@wuchunfu wuchunfu commented Sep 1, 2022

Purpose of this pull request

close #2023

relation #2029

Check list

@wuchunfu wuchunfu changed the title Add mongodb connecter v2 source [Feature][Connector-V2] Add mongodb connecter source Sep 1, 2022
hailin0
hailin0 reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add connector-v2 e2e-testcase(flink、spark)？

reference：#2499

@wuchunfu
Copy link
Member Author

wuchunfu commented Sep 2, 2022

Can you add connector-v2 e2e-testcase(flink、spark)？

reference：#2499

Thanks for the reminder, I'll add it later, thanks.

@wuchunfu wuchunfu force-pushed the mongodb-connecter-v2-source branch 3 times, most recently from daa82fc to e504026 Compare September 3, 2022 07:37
@wuchunfu
Copy link
Member Author

wuchunfu commented Sep 3, 2022

@hailin0 @TyrantLucifer @Hisoka-X @CalvinKirs Please review it, thx.

TyrantLucifer
TyrantLucifer reviewed Sep 3, 2022
View reviewed changes
...r-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/config/Config.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceEvent.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceEvent.java Outdated Show resolved Hide resolved
...db/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSource.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceEvent.java Outdated Show resolved Hide resolved
.../main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceReader.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceSplit.java Outdated Show resolved Hide resolved
...a/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceSplitEnumerator.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/state/MongodbSourceState.java Outdated Show resolved Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/utils/RawTypeConverter.java Outdated Show resolved Hide resolved
@wuchunfu wuchunfu requested review from TyrantLucifer and hailin0 and removed request for hailin0 September 3, 2022 13:21
@wuchunfu wuchunfu requested review from EricJoy2048, TyrantLucifer and hailin0 and removed request for hailin0 September 3, 2022 15:15
TyrantLucifer
TyrantLucifer reviewed Sep 3, 2022
View reviewed changes
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/config/MongodbParameters.java Outdated Show resolved Hide resolved
...db/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSource.java Outdated Show resolved Hide resolved
...db/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSource.java Outdated Show resolved Hide resolved
.../main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceReader.java Outdated Show resolved Hide resolved
.../main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceReader.java Outdated Show resolved Hide resolved
.../main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceReader.java Outdated Show resolved Hide resolved
@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 6, 2022

Please make ci pass then this PR can be merged.

Hisoka-X
Hisoka-X approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TyrantLucifer
TyrantLucifer approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TyrantLucifer TyrantLucifer merged commit 3ee8a8a into apache:dev Sep 7, 2022
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 8, 2022
@wuchunfu @MRYOG
[Feature][Connector-V2] Add mongodb connecter source (apache#2596)
f2de788 
* Add mongodb connecter v2 source

* Add docs

* Add license header

* Add mongodb e2e

* Add license header

* Add codestyle

* change config file

* Resolve conflicts

* Add mongodb connecter v2 source

* fix

* fix

* fix

* fix

* fix

* fix

* Fix codestyle
laglangyue pushed a commit to laglangyue/seatunnel that referenced this pull request Sep 11, 2022
@wuchunfu
[Feature][Connector-V2] Add mongodb connecter source (apache#2596)
2d49095 
* Add mongodb connecter v2 source

* Add docs

* Add license header

* Add mongodb e2e

* Add license header

* Add codestyle

* change config file

* Resolve conflicts

* Add mongodb connecter v2 source

* fix

* fix

* fix

* fix

* fix

* fix

* Fix codestyle
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 15, 2022
@wuchunfu @MRYOG
[Feature][Connector-V2] Add mongodb connecter source (apache#2596)
17870e8 
* Add mongodb connecter v2 source

* Add docs

* Add license header

* Add mongodb e2e

* Add license header

* Add codestyle

* change config file

* Resolve conflicts

* Add mongodb connecter v2 source

* fix

* fix

* fix

* fix

* fix

* fix

* Fix codestyle
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
@wuchunfu @MRYOG
[Feature][Connector-V2] Add mongodb connecter source (apache#2596)
f183bde 
* Add mongodb connecter v2 source

* Add docs

* Add license header

* Add mongodb e2e

* Add license header

* Add codestyle

* change config file

* Resolve conflicts

* Add mongodb connecter v2 source

* fix

* fix

* fix

* fix

* fix

* fix

* Fix codestyle
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@wuchunfu @TyrantLucifer
[Feature][Connector-V2] Add mongodb connecter source (apache#2596)
26e5044 
* Add mongodb connecter v2 source

* Add docs

* Add license header

* Add mongodb e2e

* Add license header

* Add codestyle

* change config file

* Resolve conflicts

* Add mongodb connecter v2 source

* fix

* fix

* fix

* fix

* fix

* fix

* Fix codestyle
@wuchunfu wuchunfu deleted the mongodb-connecter-v2-source branch November 26, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun

@EricJoy2048 EricJoy2048 Awaiting requested review from EricJoy2048

@hailin0 hailin0 Awaiting requested review from hailin0

Assignees
No one assigned
Labels
connectors-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[api-draft][connector] Add MongoDB source connector
5 participants
@wuchunfu @Hisoka-X @hailin0 @EricJoy2048 @TyrantLucifer