Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Add redis sink connector #2647

Merged
merged 11 commits into from
Sep 7, 2022

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

#1946 Redis sink connector

Check list

@TyrantLucifer
Copy link
Member Author

@CalvinKirs @EricJoy2048 @hailin0 PTAL.

EricJoy2048
EricJoy2048 previously approved these changes Sep 5, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether some connection parameters of jedis need to be handed over to the user for configuration

@TyrantLucifer
Copy link
Member Author

TyrantLucifer commented Sep 5, 2022

Whether some connection parameters of jedis need to be handed over to the user for configuration

The first version in the absence of a large amount of data stress testing is not clear whether some parameters need additional tuning and configuration, I think the first version for the time being to achieve the function, wait until the later unified pressure test to actively expose some problems and then optimize the iteration, for the time being, the default parameters of jedis is sufficient for users to use. What do you think about it?

@CalvinKirs CalvinKirs merged commit 71a9e4b into apache:dev Sep 7, 2022
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 8, 2022
laglangyue pushed a commit to laglangyue/seatunnel that referenced this pull request Sep 11, 2022
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 15, 2022
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
TyrantLucifer added a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants