-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Add redis sink connector #2647
Conversation
@CalvinKirs @EricJoy2048 @hailin0 PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether some connection parameters of jedis need to be handed over to the user for configuration
The first version in the absence of a large amount of data stress testing is not clear whether some parameters need additional tuning and configuration, I think the first version for the time being to achieve the function, wait until the later unified pressure test to actively expose some problems and then optimize the iteration, for the time being, the default parameters of jedis is sufficient for users to use. What do you think about it? |
...is/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java
Outdated
Show resolved
Hide resolved
...is/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java
Outdated
Show resolved
Hide resolved
...is/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java
Show resolved
Hide resolved
...edis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisDataType.java
Show resolved
Hide resolved
3901aa8
to
c0186fe
Compare
Purpose of this pull request
#1946 Redis sink connector
Check list
New License Guide