Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][e2e] Improved e2e start sleep #2677

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Conversation

hailin0
Copy link
Contributor

@hailin0 hailin0 commented Sep 8, 2022

Purpose of this pull request

Improved e2e start sleep

Check list

EricJoy2048
EricJoy2048 previously approved these changes Sep 8, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laglangyue
Copy link
Contributor

image
why don't use api which is start()

@hailin0
Copy link
Contributor Author

hailin0 commented Sep 8, 2022

image why don't use api which is start()

Just to unify with other testcase

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The integration test needs to be run again.

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the latest code to resolve exceptions in e2e;

@hailin0
Copy link
Contributor Author

hailin0 commented Sep 8, 2022

image

ashulin
ashulin previously approved these changes Sep 9, 2022
CalvinKirs
CalvinKirs previously approved these changes Sep 9, 2022
@hailin0
Copy link
Contributor Author

hailin0 commented Sep 9, 2022

image

@ashulin

@ashulin ashulin merged commit 5bd96a5 into apache:dev Sep 13, 2022
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Sep 13, 2022
* [Improve][e2e] Improved e2e start sleep

* update

* update

* fix 2675
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
* [Improve][e2e] Improved e2e start sleep

* update

* update

* fix 2675
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
* [Improve][e2e] Improved e2e start sleep

* update

* update

* fix 2675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants