Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][build] delete connectors*-dist modules #2709

Merged
merged 2 commits into from
Sep 13, 2022
Merged

[Improve][build] delete connectors*-dist modules #2709

merged 2 commits into from
Sep 13, 2022

Conversation

ashulin
Copy link
Member

@ashulin ashulin commented Sep 9, 2022

Purpose of this pull request

This is a subtask belonging to #2673

test command:

mvn clean install -T 1C

before the change:
image

after the change:
image

Check list

@ashulin ashulin linked an issue Sep 9, 2022 that may be closed by this pull request
[Improve][build] Remove the connector-*dist module #2673
Closed
3 tasks
@ashulin ashulin marked this pull request as draft September 9, 2022 17:14
@ashulin ashulin marked this pull request as ready for review September 10, 2022 04:50
TyrantLucifer
TyrantLucifer approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CalvinKirs CalvinKirs merged commit 7e2bb64 into apache:dev Sep 13, 2022
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Sep 13, 2022
@ashulin
[Improve][build] delete connectors*-dist modules (apache#2709)
b08c403
@ashulin ashulin deleted the improve/remove-connector-dist branch September 14, 2022 09:12
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
@ashulin @MRYOG
[Improve][build] delete connectors*-dist modules (apache#2709)
9b27a2d
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@ashulin @TyrantLucifer
[Improve][build] delete connectors*-dist modules (apache#2709)
430b950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][build] Remove the connector-*dist module
4 participants
@ashulin @hailin0 @CalvinKirs @TyrantLucifer