[Feature][Connector2] Add DingTalk Source #2684 #2757
Conversation
| <dependency> | ||
| <groupId>org.apache.seatunnel</groupId> | ||
| <artifactId>connector-http-base</artifactId> | ||
| <version>2.1.3-SNAPSHOT</version> |
There was a problem hiding this comment.
| <version>2.1.3-SNAPSHOT</version> | |
| <version>${project.version}</version> |
| <dependency> | ||
| <groupId>com.aliyun</groupId> | ||
| <artifactId>dingtalk</artifactId> | ||
| <version>1.4.26</version> | ||
| </dependency> |
There was a problem hiding this comment.
I checked the DingTalk documentation, this is the new version of the sdk; so can the old version of the sdk(alibaba-dingtalk-service-sdk) be removed?
There was a problem hiding this comment.
old sdk version is used by sink plugin , next sink plugin update will be remove
| protected final DingTalkParameter dtParameter; | ||
| protected DingTalkClient dtClient; | ||
| protected OapiV2DepartmentListsubRequest dtRequest; | ||
| protected final DeserializationSchema<SeaTunnelRow> deserializationSchema; |
| } | ||
| } | ||
| } | ||
| LOGGER.error("Ding Talk client execute exception, response status code:[{}], content:[{}]", response.getErrorCode(), response.getBody()); |
There was a problem hiding this comment.
Output error log under any circumstances？I think you need else here.
| ## Key features | ||
|
|
||
| - [x] [batch](../../concept/connector-v2-features.md) | ||
| - [ ] [stream](../../concept/connector-v2-features.md) |
There was a problem hiding this comment.
It can be seen from the code that the connector supports the stream module. Please check it.
| |-----------| ---------- | -------- | ------------- | | ||
| | api_client | string | yes | - | | ||
| | access_token | string | yes | - | | ||
| | app_key | string | yes | - | |
| GetAccessTokenResponse res = client.getAccessToken(getAccessTokenRequest); | ||
| appToken = res.getBody().getAccessToken(); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Use slf4j logger error and throw Exception?
|
|
||
| if (pluginConfig.hasPath(DingTalkConstant.SCHEMA)) { | ||
| Config schema = pluginConfig.getConfig(DingTalkConstant.SCHEMA); | ||
| this.rowType = SeaTunnelSchema.buildWithConfig(schema).getSeaTunnelRowType(); |
| String tmpContent = response.getBody(); | ||
| JsonNode bodyJson = JsonUtils.stringToJsonNode(tmpContent); | ||
| JsonNode resJson = bodyJson.get(DingTalkConstant.BODY_RESULT); | ||
| if (resJson.isArray()) { |
There was a problem hiding this comment.
If it's not an array, do you need to log exception message?
|
Please solve conflict, thanks! |
|
@MRYOG Will this pr go ahead? If not, I would like to take over and finish it |
|
This pr will be closed because there is no response for too long. |
Description
support V2 Connector for DingTalk
Usage Scenario
use DingTalk API get data