Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imporve][Connector-V2] Refactor ftp sink & Add ftp file source #2774

Merged
merged 5 commits into from
Sep 22, 2022
Merged

[Imporve][Connector-V2] Refactor ftp sink & Add ftp file source #2774

merged 5 commits into from
Sep 22, 2022

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

  1. According to pr [Improve][Connector-V2] Refactor the structure of file sink to reduce redundant codes #2555 , this pr has optimized the ftp file sink connector on top of it.
  2. Add ftp source connector

Check list

EricJoy2048
EricJoy2048 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @CalvinKirs PTAL

@EricJoy2048 EricJoy2048 mentioned this pull request Sep 21, 2022
Closed
ashulin
ashulin approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 added the don't merge There needs to be a specific reason in the PR, and it cannot be merged for the time being. label Sep 22, 2022
@EricJoy2048 EricJoy2048 merged commit 4aacbcd into apache:dev Sep 22, 2022
@Hisoka-X Hisoka-X removed the don't merge There needs to be a specific reason in the PR, and it cannot be merged for the time being. label Sep 23, 2022
@EricJoy2048 EricJoy2048 mentioned this pull request Oct 8, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@ashulin ashulin ashulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TyrantLucifer @EricJoy2048 @ashulin @Hisoka-X