Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][connector][fake] supports setting the number of split rows and reading interval #3098

Merged
merged 1 commit into from
Oct 15, 2022
Merged

[improve][connector][fake] supports setting the number of split rows and reading interval #3098

merged 1 commit into from
Oct 15, 2022

Conversation

ashulin
Copy link
Member

@ashulin ashulin commented Oct 14, 2022 •
edited
Loading

Purpose of this pull request

  1. supports setting the number of split rows
  2. supports setting splits reading interval

Check list

@ashulin ashulin force-pushed the improve/fake/control-time branch 2 times, most recently from 2bb09f9 to 07763cd Compare October 14, 2022 04:06
@ashulin
Copy link
Member Author

ashulin commented Oct 14, 2022

@EricJoy2048 @liugddx PTAL

EricJoy2048
EricJoy2048 approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TyrantLucifer
TyrantLucifer approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit efabe6a into apache:dev Oct 15, 2022
@ashulin ashulin deleted the improve/fake/control-time branch October 16, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashulin @EricJoy2048 @TyrantLucifer