Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2-Clickhouse] Clickhouse Source random use host when config multi-host #3108

Merged
merged 10 commits into from
Oct 20, 2022

Conversation

john8628
Copy link
Contributor

@john8628 john8628 commented Oct 14, 2022

Purpose of this pull request

#2806

Check list

Copy link
Contributor

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -55,6 +55,7 @@ public class ClickhouseSource implements SeaTunnelSource<SeaTunnelRow, Clickhous
private List<ClickHouseNode> servers;
private SeaTunnelRowType rowTypeInfo;
private String sql;
private final ThreadLocalRandom threadLocalRandom = ThreadLocalRandom.current();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call directly inside the method

Hisoka-X
Hisoka-X previously approved these changes Oct 16, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X
Copy link
Member

The ci failed, please fix it first. thanks

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for completion of CI.

@EricJoy2048 EricJoy2048 merged commit c9583b7 into apache:dev Oct 20, 2022
Carl-Zhou-CN pushed a commit to Carl-Zhou-CN/incubator-seatunnel that referenced this pull request Oct 27, 2022
Carl-Zhou-CN pushed a commit to Carl-Zhou-CN/incubator-seatunnel that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants