Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Connector-V2][File] Fix filesystem get error #3117

Merged
merged 1 commit into from Oct 18, 2022

Conversation

TyrantLucifer
Copy link
Member

@TyrantLucifer TyrantLucifer commented Oct 17, 2022

Purpose of this pull request

Fix the logic error of getting filesystem.

If we use new File(path).toURI() it will generate URI with file schema, so that FileSystem will always instantiate LocalFileSystem

微信截图_20221017162101

Snipaste_2022-10-17_16-21-49

Check list

@TyrantLucifer
Copy link
Member Author

@ashulin @EricJoy2048 PTAL.

@TyrantLucifer TyrantLucifer changed the title [Feature][Connector-V2][File] Fix filesystem get error [Hotfix][Connector-V2][File] Fix filesystem get error Oct 17, 2022
Copy link
Contributor

@dijiekstra dijiekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 7404c18 into apache:dev Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants