[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/en/connector-v2/sink/Kafka.md # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
TaoZex
reviewed
Dec 14, 2022
hailin0
previously approved these changes
Dec 16, 2022
Co-authored-by: TaoZex <45089228+TaoZex@users.noreply.github.com>
EricJoy2048
previously approved these changes
Dec 26, 2022
CalvinKirs
previously approved these changes
Dec 26, 2022
Yes, We can add reason on next version change-log. |
Hisoka-X
dismissed stale reviews from CalvinKirs and EricJoy2048
via
ac1e9e8
EricJoy2048
approved these changes
Dec 30, 2022
TaoZex
approved these changes
Jan 2, 2023
CalvinKirs
approved these changes
Jan 3, 2023
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
…apache#3719) * [Improve] [Connector-V2] Change Connector Custom Config Prefix To Map
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
…apache#3719) * [Improve] [Connector-V2] Change Connector Custom Config Prefix To Map
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide