[Improve] [Connector-V2] Kafka client user configured clientid is preferred #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser side is preferred; otherwise, the default clientid is set.
Hisoka-X
added
First-time contributor
Hisoka-X
changed the title
Hisoka-X
reviewed
Dec 22, 2022
| @@ -68,7 +68,12 @@ private KafkaConsumer<byte[], byte[]> initConsumer(String bootstrapServer, Strin | |||
| properties.forEach((key, value) -> props.setProperty(String.valueOf(key), String.valueOf(value))); | |||
| props.setProperty(ConsumerConfig.GROUP_ID_CONFIG, consumerGroup); | |||
| props.setProperty(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServer); | |||
| props.setProperty(ConsumerConfig.CLIENT_ID_CONFIG, CLIENT_ID_PREFIX + "-consumer-" + this.hashCode()); | |||
| if(this.metadata.getProperties().get("client.id") == null){ | |||
There was a problem hiding this comment.
Please format the code. thanks
There was a problem hiding this comment.
Format code completed, thank you.
liugddx
approved these changes
Dec 24, 2022
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
…ferred (apache#3783) * If the clientid is configured on the user side, the clientid on the user side is preferred; otherwise, the default clientid is set. * format code style Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
…ferred (apache#3783) * If the clientid is configured on the user side, the clientid on the user side is preferred; otherwise, the default clientid is set. * format code style Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the clientid is configured on the user side, the clientid on the user side is preferred; otherwise, the default clientid is set.
Purpose of this pull request
Check list
New License Guide