Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] [Engine] Fix Engine Metrics will lose when Job be canceled. #3797

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

  1. Change pipeline slot resource release time. Both pipeline failed/cancel/finished always release slot resource now.
  2. Storing metrics at the pipeline level, each pipeline will store metrics to JobHistoryService before release resource, not job level.

Check list

Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit ca06ea1 into apache:dev Jan 3, 2023
@Hisoka-X Hisoka-X deleted the jobmaster_and_metrics branch January 17, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants