[Improve][JDBC] improve jdbc sink option #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoZex
reviewed
Jan 4, 2023
| @@ -46,22 +47,20 @@ public class JdbcConfig implements Serializable { | |||
|
|
|||
| public static final Option<Boolean> AUTO_COMMIT = Options.key("auto_commit").booleanType().defaultValue(DEFAULT_AUTO_COMMIT).withDescription("auto commit"); | |||
|
|
|||
| public static final Option<Integer> BATCH_SIZE = Options.key("batch_size").intType().noDefaultValue().withDescription("batch size"); | |||
| public static final Option<Integer> BATCH_SIZE = Options.key("batch_size").intType().defaultValue(1000).withDescription("batch size"); | |||
There was a problem hiding this comment.
Why set batch size 1000 as the default value, does it improve the efficiency of jdbc?
There was a problem hiding this comment.
Theoretically, the performance would be better if the value was higher, but I didn't test.
hailin0
approved these changes
Jan 6, 2023
EricJoy2048
added a commit
to EricJoy2048/incubator-seatunnel
that referenced
this pull request
Jan 6, 2023
* improve jdbc sink option * improve option default get
EricJoy2048
added a commit
to EricJoy2048/incubator-seatunnel
that referenced
this pull request
Jan 6, 2023
* improve jdbc sink option * improve option default get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.