Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][SourceConnector] Unifie InfluxDB source fields to schema #3897

Merged

Conversation

wfrong
Copy link
Contributor

@wfrong wfrong commented Jan 9, 2023

Purpose of this pull request

fix #3821
Unifie InfluxDB source fields to schema

Check list

@liugddx liugddx added the First-time contributor First-time contributor label Jan 9, 2023
@wfrong
Copy link
Contributor Author

wfrong commented Jan 10, 2023

cc @Hisoka-X @liugddx , could you help me review this PR?

@liugddx
Copy link
Member

liugddx commented Jan 10, 2023

cc @Hisoka-X @liugddx , could you help me review this PR?
Let's wait for CI.

@wfrong
Copy link
Contributor Author

wfrong commented Jan 11, 2023

cc @Hisoka-X @liugddx , could you help me review this PR?
Let's wait for CI.
I have resolved e2e module CI error , could you please restart CI ?thx

@Hisoka-X
Copy link
Member

cc @Hisoka-X @liugddx , could you help me review this PR?
Let's wait for CI.
I have resolved e2e module CI error , could you please restart CI ?thx

Hi, seem like you not update your code after resolved e2e module CI error. If you update the code, the ci will auto restart

change schema type to config

Co-authored-by: Guangdong Liu <804167098@qq.com>
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer
Copy link
Member

Let's waiting CI process. Thanks, if CI passed this pull request can be merged.

@EricJoy2048 EricJoy2048 merged commit 85a984a into apache:dev Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][SourceConnector] Unified schema parameter, update InfluxDB Source fields to schema
5 participants