Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [Seatunnel-Engine] Fix NEP when scheduling sub plan fails. #3909

Merged
merged 17 commits into from
Jan 17, 2023
Merged

[Bug] [Seatunnel-Engine] Fix NEP when scheduling sub plan fails. #3909

merged 17 commits into from
Jan 17, 2023

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Jan 10, 2023 •
edited

close #3908

Purpose of this pull request

Check list

@hailin0
Copy link
Contributor

hailin0 commented Jan 11, 2023

please fix ci error

@liugddx
Copy link
Member Author

liugddx commented Jan 15, 2023

@hailin0 @EricJoy2048 PTAL thanks.

@hailin0
Copy link
Contributor

hailin0 commented Jan 17, 2023

Title: Fix NEP when scheduling sub plan fails

@liugddx liugddx changed the title [Bug] [Seatunnel-Engine] Fix when sub plan scheduling fails a NPE will happen. [Bug] [Seatunnel-Engine] Fix NEP when scheduling sub plan fails. Jan 17, 2023
@liugddx
Copy link
Member Author

liugddx commented Jan 17, 2023

Title: Fix NEP when scheduling sub plan fails

Done.

ashulin
ashulin approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashulin ashulin merged commit 9df0094 into apache:dev Jan 17, 2023
@liugddx liugddx deleted the bugfix-NPE branch March 20, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@ashulin ashulin ashulin approved these changes

@EricJoy2048 EricJoy2048 Awaiting requested review from EricJoy2048

Assignees
No one assigned
Labels
approved bug reviewed Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Seatunnel-Engine] when sub plan scheduling fails，a NPE will happen.
4 participants
@liugddx @hailin0 @EricJoy2048 @ashulin