Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Zeta] Statistics server job and system resource usage #3980 #3982

Merged
merged 4 commits into from
Feb 2, 2023
Merged

[Improve][Zeta] Statistics server job and system resource usage #3980 #3982

merged 4 commits into from
Feb 2, 2023

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Jan 19, 2023

close #3980

Purpose of this pull request

Check list

@2000liux
Copy link

nice

@liugddx
Copy link
Member Author

liugddx commented Jan 28, 2023

image

EricJoy2048
EricJoy2048 reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release note to /release-note.md

@EricJoy2048
Copy link
Member

image

I'm worried that if there are many slots in a single node, will the log output here take up too much space? Will this affect the problem we define through the log?

@liugddx
Copy link
Member Author

liugddx commented Jan 31, 2023

slots
I agree. I will provide other ways to get system resources.

@liugddx
Copy link
Member Author

liugddx commented Feb 1, 2023

image

Hisoka-X
Hisoka-X previously approved these changes Feb 1, 2023
View reviewed changes
@liugddx liugddx added the don't merge There needs to be a specific reason in the PR, and it cannot be merged for the time being. label Feb 1, 2023
@liugddx
Copy link
Member Author

liugddx commented Feb 1, 2023

please wait #4028

@liugddx liugddx removed the don't merge There needs to be a specific reason in the PR, and it cannot be merged for the time being. label Feb 2, 2023
@liugddx
Merge remote-tracking branch 'upstream/dev' into improve-stats
cff80b3 
# Conflicts:
#	seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java
#	seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceTwoPipelineIT.java
@liugddx
disabled
bf24283
@liugddx liugddx requested a review from Hisoka-X February 2, 2023 04:52
@Hisoka-X Hisoka-X merged commit 996731d into apache:dev Feb 2, 2023
@liugddx liugddx deleted the improve-stats branch March 20, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved improve reviewed Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Zeta] Statistics server job and system resource usage
4 participants
@liugddx @2000liux @EricJoy2048 @Hisoka-X