Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][E2E][Clickhouse] Fix the bug of clickhouse e2e case #3985

Merged
merged 5 commits into from
Jan 20, 2023
Merged

[Hotfix][E2E][Clickhouse] Fix the bug of clickhouse e2e case #3985

merged 5 commits into from
Jan 20, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Check list

@TyrantLucifer TyrantLucifer mentioned this pull request Jan 20, 2023
Merged
5 tasks
@hailin0
Copy link
Contributor

hailin0 commented Jan 20, 2023

title：[Bug][E2E][Clickhouse] Fix clickhouse e2e testcase

@TyrantLucifer TyrantLucifer changed the title [Feature][E2E][Clickhouse] Improve stability of clickhouse e2e [Improve][E2E][Clickhouse] Improve stability of clickhouse e2e Jan 20, 2023
@TyrantLucifer TyrantLucifer changed the title [Improve][E2E][Clickhouse] Improve stability of clickhouse e2e [Hotfix][E2E][Clickhouse] Fix the bug of clickhouse e2e case Jan 20, 2023
@TyrantLucifer
Copy link
Member Author

title：[Bug][E2E][Clickhouse] Fix clickhouse e2e testcase

Done.

hailin0
hailin0 previously approved these changes Jan 20, 2023
View reviewed changes
dijiekstra
dijiekstra previously approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@dijiekstra dijiekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wuchunfu
wuchunfu approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit 714511a into apache:dev Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@wuchunfu wuchunfu wuchunfu approved these changes

@hailin0 hailin0 hailin0 left review comments

@dijiekstra dijiekstra dijiekstra left review comments

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TyrantLucifer @hailin0 @CalvinKirs @dijiekstra @wuchunfu