Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Connector-V2][ES]Fix es source no data #4076

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

kpretty
Copy link
Contributor

@kpretty kpretty commented Feb 7, 2023

Purpose of this pull request

repair the index of complex mapping, the data cannot be obtained through the form of a.b
For example
index of mapping

{
  "arkime_sessions3-221123": {
    "mappings": {
      "properties": {
        "@timestamp": {
          "type": "date"
        },
        "@version": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "agent": {
          "properties": {
            "build": {
              "properties": {
                "original": {
                  "type": "keyword",
                  "ignore_above": 1024
                }
              }
            },
            "ephemeral_id": {
              "type": "keyword",
              "ignore_above": 1024
            },
            "id": {
              "type": "keyword",
              "ignore_above": 1024
            },
            "name": {
              "type": "keyword",
              "ignore_above": 1024
            },
            "type": {
              "type": "keyword",
              "ignore_above": 1024
            },
            "version": {
              "type": "keyword",
              "ignore_above": 1024
            }
          }
        }
      }
    }
  }
}

The current code configuration is as follows: no data can be obtained

source = ["agent.name"]

This PR fixes this bug

Check list

EricJoy2048
EricJoy2048 previously approved these changes Feb 8, 2023
Comment on lines 379 to 380
// JsonNode typeNode = iter.next();
// JsonNode properties = typeNode.get("properties");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless code removed

hailin0
hailin0 previously approved these changes Feb 9, 2023
@hailin0 hailin0 closed this Feb 13, 2023
@hailin0 hailin0 reopened this Feb 13, 2023
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit a573b8d into apache:dev Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants