Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imprve][Connector-V2][Hive] Support read text table & Column projection #4105

Merged
merged 20 commits into from
Feb 20, 2023
Merged

[Imprve][Connector-V2][Hive] Support read text table & Column projection #4105

merged 20 commits into from
Feb 20, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

close #3844

Check list

@TyrantLucifer TyrantLucifer changed the title [Imprve][Connector-V2][Hive] Support read text table [Imprve][Connector-V2][Hive] Support read text table & Column projection Feb 12, 2023
EricJoy2048
EricJoy2048 approved these changes Feb 20, 2023
View reviewed changes
docs/en/connector-v2/source/HdfsFile.md
@@ -219,6 +220,20 @@ The keytab path of kerberos

the schema fields of upstream data

### read_columns [list]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add change log for this pr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

docs/en/connector-v2/source/LocalFile.md
@@ -199,6 +200,20 @@ connector will generate data as the following:

The schema information of upstream data.

### read_columns [list]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

dijiekstra
dijiekstra approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@dijiekstra dijiekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit 717620f into apache:dev Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dijiekstra dijiekstra dijiekstra approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2][Hive] Support read text table
3 participants
@TyrantLucifer @dijiekstra @EricJoy2048