Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Connector-V2] Clickhouse File Connector failed to sink to table with settings like storage_policy #4172

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

wineternity
Copy link
Contributor

@wineternity wineternity commented Feb 20, 2023

related to #4003

Purpose of this pull request

Check list

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add e2e test for this pr?

@wineternity
Copy link
Contributor Author

Can you add e2e test for this pr?

OK

@Hisoka-X
Copy link
Member

Hisoka-X commented Mar 4, 2023

Hi, any progress?

@wineternity
Copy link
Contributor Author

Hi, any progress?

may be next week, try to add a e2e case

@wineternity
Copy link
Contributor Author

Can you add e2e test for this pr?

@liugddx @Hisoka-X hi, I found it is a little bit difficult to add an e2e for ClickhouseFile sink. After finished add ssh service to clickhouse images, it still need to add clickhouse-local client in flink taskmanager or spark executor docker image. Could we just ignore this ? The pr is tested in the real environment.

@Hisoka-X
Copy link
Member

Hisoka-X commented Mar 5, 2023

Can you add e2e test for this pr?

@liugddx @Hisoka-X hi, I found it is a little bit difficult to add an e2e for ClickhouseFile sink. After finished add ssh service to clickhouse images, it still need to add clickhouse-local client in flink taskmanager or spark executor docker image. Could we just ignore this ? The pr is tested in the real environment.

Ok for me, I will add e2e for clickhousefile later.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx liugddx merged commit e120dc4 into apache:dev Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants