Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][shade] Add guava shade module #4358

Merged
merged 1 commit into from
Apr 8, 2023
Merged

[Feature][shade] Add guava shade module #4358

merged 1 commit into from
Apr 8, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Check list

Al-assad
Al-assad approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Al-assad Al-assad left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

EricJoy2048
EricJoy2048 reviewed Mar 24, 2023
View reviewed changes
seatunnel-shade/seatunnel-guava/pom.xml
</filters>
<relocations>
<relocation>
<pattern>com.google</pattern>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not com.google.guava ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's crazy.

@hailin0 hailin0 merged commit be9caf3 into apache:dev Apr 8, 2023
1 check passed
MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
@TyrantLucifer @MonsterChenzhuo
[Feature][shade] Add guava shade module (apache#4358)
0087c88
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
@TyrantLucifer @EricJoy2048
[Feature][shade] Add guava shade module (apache#4358)
ae6cab8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Al-assad Al-assad Al-assad approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@lightzhao lightzhao lightzhao approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TyrantLucifer @hailin0 @Al-assad @EricJoy2048 @lightzhao