-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2][Kafka]Kafka source supports data deserializat… #4364
[Feature][Connector-V2][Kafka]Kafka source supports data deserializat… #4364
Conversation
a4c25ba
to
e9e7601
Compare
Add e2e test case to verify this pull reqeust. Thanks |
The function configuration has been added to the kafka-e2e project, and the local docker verification has been completed. Thanks. |
BTW, SeaTunnel use the spotless plugin to guarantee the style of code, so before you submit pull reqeuest you should execute |
Thanks a lot for the reminder. [INFO] SeaTunnel : E2E : Connector V2 : DataHub ........... SUCCESS [ 0.015 s] |
e9e7601
to
22f4cfa
Compare
…ion failure skipping apache#4361 [Feature][Connector-V2][Kafka]Kafka source supports data deserialization failure skipping apache#4361
1. change log level 2. add kafka source changeLog
add changelog
22f4cfa
to
9183d7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an e2e case to do the following things:
- Send different format messages to kafka and setting way to
fail
- Send different format messages to kafka and setting way to
skip
You can refer to this case KafkaIT
.
...-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java
Outdated
Show resolved
Hide resolved
...-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java
Outdated
Show resolved
Hide resolved
...-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java
Outdated
Show resolved
Hide resolved
…he/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java Co-authored-by: Tyrantlucifer <tyrantlucifer@apache.org>
seatunnel-api/src/main/java/org/apache/seatunnel/api/serialization/DeserializationSchema.java
Show resolved
Hide resolved
maybe we need to collect the dirty data about this by engine,it's very important featur about ETL sofeware, Actually, this pr can slove the serialization of kafka data,can we get the more detail reason about serialization failure,sometimes,we need such feature as |
1、format_error_handle_way = fail The data is invalid, an exception will be thrown 2、skip The data is invalid and will be skipped
seatunnel-api/src/main/java/org/apache/seatunnel/api/serialization/DeserializationSchema.java
Outdated
Show resolved
Hide resolved
ok. I have added e2e 1、format_error_handle_way = fail |
unify exception
...-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's waiting CI/CD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need fix e2e test cases
fixed |
Co-authored-by: Eric <gaojun2048@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix code-style
…tion failure skipping (apache#4364) * [Feature][Connector-V2][Kafka]Kafka source supports data deserialization failure skipping apache#4361 [Feature][Connector-V2][Kafka]Kafka source supports data deserialization failure skipping apache#4361 * change log level and add changelog 1. change log level 2. add kafka source changeLog * add changelog add changelog * add e2e add e2e * add e2e case * [Feature][Connector-V2][Kafka] Fix code style * Update seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java Co-authored-by: Tyrantlucifer <tyrantlucifer@apache.org> * fix code-review * add e2e case for format_error_handle_way 1、format_error_handle_way = fail The data is invalid, an exception will be thrown 2、skip The data is invalid and will be skipped * unify exception unify exception * change e2e config * fix e2e test case * Update docs/en/connector-v2/source/kafka.md Co-authored-by: Eric <gaojun2048@gmail.com> * Update kafka.md fix code-style --------- Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com> Co-authored-by: Tyrantlucifer <tyrantlucifer@apache.org> Co-authored-by: Eric <gaojun2048@gmail.com>
…tion failure skipping (apache#4364) * [Feature][Connector-V2][Kafka]Kafka source supports data deserialization failure skipping apache#4361 [Feature][Connector-V2][Kafka]Kafka source supports data deserialization failure skipping apache#4361 * change log level and add changelog 1. change log level 2. add kafka source changeLog * add changelog add changelog * add e2e add e2e * add e2e case * [Feature][Connector-V2][Kafka] Fix code style * Update seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java Co-authored-by: Tyrantlucifer <tyrantlucifer@apache.org> * fix code-review * add e2e case for format_error_handle_way 1、format_error_handle_way = fail The data is invalid, an exception will be thrown 2、skip The data is invalid and will be skipped * unify exception unify exception * change e2e config * fix e2e test case * Update docs/en/connector-v2/source/kafka.md Co-authored-by: Eric <gaojun2048@gmail.com> * Update kafka.md fix code-style --------- Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com> Co-authored-by: Tyrantlucifer <tyrantlucifer@apache.org> Co-authored-by: Eric <gaojun2048@gmail.com>
…ion failure skipping #4361
[Feature][Connector-V2][Kafka]Kafka source supports data deserialization failure skipping #4361
Purpose of this pull request
Check list
New License Guide
release-note
.