-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][Connector-v2][KafkaSource]Fix KafkaConsumerThread exit caused by commit offset error. #4379
[Bug][Connector-v2][KafkaSource]Fix KafkaConsumerThread exit caused by commit offset error. #4379
Conversation
Now this running workflow needs to be approved to run? Please approve the operation. |
} catch (InterruptedException e) { | ||
throw new KafkaConnectorException( | ||
KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR, e); | ||
} catch (Exception e) { | ||
throw new KafkaConnectorException( | ||
KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR, e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Exception is used here, does the above catch still make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it doesn't make sense, thanks for the reminder.
CI is error, there may be some problem to deal with |
This CI detection feels unstable, and this kind of problem occurs from time to time, and I don’t know how to deal with it. I pulled the latest code and submitted it. Local compilation is also normal. Have you encountered it? How is it handled? |
Wating for #4391 done. |
ok. |
All checks have passed, PTAL. |
…y commit offset error. (apache#4379) * Fix KafkaConsumerThread exit caused by commit offset error. * Remove redundant exception catching. --------- Co-authored-by: lightzhao <zhaolianyong777@gmail.com>
…y commit offset error. (apache#4379) * Fix KafkaConsumerThread exit caused by commit offset error. * Remove redundant exception catching. --------- Co-authored-by: lightzhao <zhaolianyong777@gmail.com>
Purpose of this pull request
When starting to consume kafka for the first time, since the initialized offset is -1, an exception will occur when submitting the kafka offset, resulting in KafkaConsumerThread not catching the exception, causing the thread to exit and unable to consume subsequent messages.
Check list
New License Guide
release-note
.