Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Transform2] Add UDF SPI and a example implement for SQL Transform plugin #4392

Merged
merged 11 commits into from
Mar 24, 2023
Merged

[Feature][Transform2] Add UDF SPI and a example implement for SQL Transform plugin #4392

merged 11 commits into from
Mar 24, 2023

Conversation

rewerma
Copy link
Contributor

@rewerma rewerma commented Mar 22, 2023

Purpose of this pull request

Add UDF SPI and a example implement for SQL Transform plugin

Check list

TyrantLucifer
TyrantLucifer previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @EricJoy2048 @hailin0

@EricJoy2048
Copy link
Member

That's great. This is a very important feature for SeaTunnel. Thank you for your contribution.

EricJoy2048
EricJoy2048 reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's wait for the CI complete.

hailin0
hailin0 reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@hailin0 hailin0 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

TyrantLucifer
TyrantLucifer approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @EricJoy2048 @hailin0

Hisoka-X
Hisoka-X approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit afee5de into apache:dev Mar 24, 2023
@rewerma rewerma deleted the feature/trans_sql_udf branch March 25, 2023 20:38
MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
@rewerma @MonsterChenzhuo
[Feature][Transform2] Add UDF SPI and a example implement for SQL Tra…
fe9cf0e 
…nsform plugin (apache#4392)


---------

Co-authored-by: mcy <rewrma@163.com>
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
@rewerma @ic4y
[Feature][Transform2] Add UDF SPI and a example implement for SQL Tra…
afad0a7 
…nsform plugin (apache#4392)


---------

Co-authored-by: mcy <rewrma@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 left review comments

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rewerma @EricJoy2048 @hailin0 @Hisoka-X @TyrantLucifer