Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][E2E] Fix kafka e2e testcase #4520

Merged
merged 4 commits into from
Apr 8, 2023
Merged

[Bug][E2E] Fix kafka e2e testcase #4520

merged 4 commits into from
Apr 8, 2023

Conversation

laglangyue
Copy link
Contributor

Purpose of this pull request

  1. I found some code plagiarism, but incomplete copying caused bugs,so I delete the Class named KafkaContainer
    https://github.com/testcontainers/testcontainers-java/blob/main/modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java

  2. some improvement for canalIT

Check list

@laglangyue laglangyue changed the title [Bug] fix kafka e2e bug，remove the customer implement for KafkaContainer [Bug] fix kafka e2e bug,remove the customer implement for KafkaContainer Apr 7, 2023
@laglangyue
Copy link
Contributor Author

image

@laglangyue
Copy link
Contributor Author

@hailin0 @TyrantLucifer

@laglangyue laglangyue changed the title [Bug] fix kafka e2e bug,remove the customer implement for KafkaContainer [Bug] fix kafka e2e:remove the customer implement for KafkaContainer and improve the allocation of host:port Apr 7, 2023
@laglangyue laglangyue changed the title [Bug] fix kafka e2e:remove the customer implement for KafkaContainer and improve the allocation of host:port [Bug] fix kafka e2e:remove the custome implement for KafkaContainer and improve the allocation of host:port Apr 7, 2023
@hailin0 hailin0 changed the title [Bug] fix kafka e2e:remove the custome implement for KafkaContainer and improve the allocation of host:port [Bug][E2E] Fix kafka e2e testcase Apr 8, 2023
@hailin0 hailin0 mentioned this pull request Apr 8, 2023
Closed
5 tasks
ashulin
ashulin approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashulin ashulin merged commit fbd05b3 into apache:dev Apr 8, 2023
27 checks passed
@TyrantLucifer TyrantLucifer mentioned this pull request Apr 8, 2023
Merged
5 tasks
MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
@laglangyue @MonsterChenzhuo
[Bug][E2E] Fix kafka e2e testcase (apache#4520)
43fa220 
* fix ci e2e

* fix ci e2e

* fix ci e2e

* fix ci e2e

---------

Co-authored-by: tangjiafu <jiafu.tang@qq.com>
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
@laglangyue @EricJoy2048
[Bug][E2E] Fix kafka e2e testcase (apache#4520)
eeb14cc 
* fix ci e2e

* fix ci e2e

* fix ci e2e

* fix ci e2e

---------

Co-authored-by: tangjiafu <jiafu.tang@qq.com>
@laglangyue laglangyue deleted the canal branch October 26, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@ashulin ashulin ashulin approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laglangyue @hailin0 @ashulin