Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector-v2] add amazondynamicdb source split #5275

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

john8628
Copy link
Contributor

@john8628 john8628 commented Aug 10, 2023

Purpose of this pull request

#5250

Check list

@john8628 john8628 force-pushed the feat/amazondynamodb_split branch 2 times, most recently from cf0789e to f8ca27e Compare August 13, 2023 09:12
@john8628
Copy link
Contributor Author

@liugddx PTAL

@zhilinli123
Copy link
Contributor

zhilinli123 commented Sep 11, 2023

@liugddx
Copy link
Member

liugddx commented Sep 17, 2023

Please resolve code conflicts.

@john8628
Copy link
Contributor Author

Good Job, Can you modify the connector document? Please refer to it for details reference:https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/Mysql.mdhttps://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/Mysql.md?plain=1

yean , i had modifed the doc, and help to review ;

@hailin0
Copy link
Member

hailin0 commented Oct 20, 2023

Please resolve code conflicts.

@hailin0
Copy link
Member

hailin0 commented Oct 25, 2023

conflict fixed

@hailin0
Copy link
Member

hailin0 commented Oct 25, 2023

Waiting for ci to succeed

@john8628
Copy link
Contributor Author

sorry for the late reply, and thank you for your work;

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx liugddx merged commit 740c144 into apache:dev Oct 25, 2023
6 checks passed
@john8628 john8628 deleted the feat/amazondynamodb_split branch October 26, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants