Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][E2E] Update Test Container Version of SeaTunnel engine #5323

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[Hotfix][E2E] Update Test Container Version of SeaTunnel engine #5323

merged 1 commit into from
Aug 23, 2023

Conversation

CheneyYin
Copy link
Contributor

@CheneyYin CheneyYin commented Aug 17, 2023 •
edited
Loading

Purpose of this pull request

Check list

@CheneyYin CheneyYin force-pushed the update-seatunnel-test-container-version branch from b8721f7 to 3708f66 Compare August 17, 2023 03:11
@CheneyYin CheneyYin changed the title [Hotfix][E2E] Update SeatTunnel Test Container Version [Hotfix][E2E] Update Test Container Version of SeaTunnel engine Aug 17, 2023
@CheneyYin CheneyYin marked this pull request as ready for review August 17, 2023 03:12
@CheneyYin CheneyYin force-pushed the update-seatunnel-test-container-version branch from 3708f66 to 8bf8a88 Compare August 23, 2023 01:40
Hisoka-X
Hisoka-X reviewed Aug 23, 2023
View reviewed changes
...nnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/TestContainerId.java Outdated
@@ -32,7 +32,7 @@ public enum TestContainerId {
FLINK_1_16(FLINK, "1.16.0"),
SPARK_2_4(SPARK, "2.4.6"),
SPARK_3_3(SPARK, "3.3.0"),
SEATUNNEL(EngineType.SEATUNNEL, "2.3.1");
SEATUNNEL(EngineType.SEATUNNEL, "latest");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about dev?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 dev is appropriate.

@CheneyYin CheneyYin force-pushed the update-seatunnel-test-container-version branch from 8bf8a88 to 8dd62b6 Compare August 23, 2023 10:37
@CheneyYin CheneyYin force-pushed the update-seatunnel-test-container-version branch from 8dd62b6 to cc106f4 Compare August 23, 2023 10:39
Hisoka-X
Hisoka-X approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CheneyYin

@liugddx liugddx merged commit e181eee into apache:dev Aug 23, 2023
54 checks passed
@CheneyYin CheneyYin deleted the update-seatunnel-test-container-version branch August 24, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@liugddx liugddx liugddx approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Hotfix] [E2E] The version of SeatTunnel Engine in TestContainerId is too old
3 participants
@CheneyYin @Hisoka-X @liugddx