[Feature][Catalog] Catalog add Case Conversion Definition

[XiaoJiang521]

Purpose of this pull request

Check list

• Code changed are covered with tests, or it does not need tests for reason:
• If any new Jar binary package adding in your PR, please add License Notice according
  New License Guide
• If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
• If you are contributing the connector code, please check that the following files are updated:
  1. Update change log that in connector document. For more details you can refer to connector-v2
  2. Update plugin-mapping.properties and add new connector information in it
  3. Update the pom file of seatunnel-dist
• Update the release-note.

[Hisoka-X]

There are so many same String.format for same purpose. Could you refactor it? Please.

[Hisoka-X]

Suggested change

// String columnNamesString = String.join(", ", primaryKey.getColumnNames());

[Hisoka-X]

Put fieldIde as PostgresCreateTableSqlBuilder field, so you don't need it as parameter for much methods.

[XiaoJiang521]

ok

[Hisoka-X]

I'm a litttle curious, where did you get the name: FieldIde？ Because it just LetterCase

[XiaoJiang521]

field identifier😂 I'm not sure if this is acceptable either.

[Hisoka-X]

How about IdentifierCase?

[Hisoka-X]

Is any possible we can create AbstractCreateTableSqlBuilder to define common behavior of OracleCreateTableSqlBuilder, MySQLCreateTableSqlBuilder so on?

[XiaoJiang521]

Is any possible we can create AbstractCreateTableSqlBuilder to define common behavior of OracleCreateTableSqlBuilder, MySQLCreateTableSqlBuilder so on?

ok

[XiaoJiang521]

There are so many same String.format for same purpose. Could you refactor it? Please.

I'm uncertain about how to refactor this part. It can be categorized into two groups: one is "SchemaAndTable," and the other is related to "getFullName." Additionally, I've introduced an overloaded method named "getFullNameWithQuoted" due to cases involving both field and [field]. Could you provide some suggestions for refactoring

[XiaoJiang521]

AbstractCreateTableSqlBuilder

The four classes, namely MysqlCreateTableSqlBuilder, OracleCreateTableSqlBuilder, PostgresCreateTableSqlBuilder, and SqlServerCreateTableSqlBuilder, share some commonality only between OracleCreateTableSqlBuilder and PostgresCreateTableSqlBuilder. For the rest, aside from class attributes that can be extracted into an abstract class, there doesn't appear to be much commonality to extract since each database requires its own unique table creation SQL construction and they differ significantly. Would it still be necessary to create an abstract class called AbstractCreateTableSqlBuilder for this situation?

[Hisoka-X]

AbstractCreateTableSqlBuilder

The four classes, namely MysqlCreateTableSqlBuilder, OracleCreateTableSqlBuilder, PostgresCreateTableSqlBuilder, and SqlServerCreateTableSqlBuilder, share some commonality only between OracleCreateTableSqlBuilder and PostgresCreateTableSqlBuilder. For the rest, aside from class attributes that can be extracted into an abstract class, there doesn't appear to be much commonality to extract since each database requires its own unique table creation SQL construction and they differ significantly. Would it still be necessary to create an abstract class called AbstractCreateTableSqlBuilder for this situation?

I see, we can do it later after we have catalog module.