Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Zeta] Fix the problem of unstable job status #5450

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

EricJoy2048
Copy link
Member

@EricJoy2048 EricJoy2048 commented Sep 8, 2023

Purpose of this pull request

Fix #5342

Reconstructed the scheduling process for Jobs, Pipelines, and Tasks. Change to state driven.

Modified the status types of Job, Pipeline, and Task.

Does this PR introduce any user-facing change?

No

How was this patch tested?

e2e already exists

Check list

@EricJoy2048 EricJoy2048 changed the title [WIP][Zeta] Improve job scheduler [Hotfix][Zeta] Fix the problem of unstable job status Sep 13, 2023
Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And turn on CheckpointTimeOutTest#testJobLevelCheckpointTimeOut

@ruanwenjun
Copy link
Member

ruanwenjun commented Sep 15, 2023

CI failed, please make sure your dev branch has rebased the upstream dev.

@EricJoy2048 EricJoy2048 force-pushed the 150_improve_job_scheduler branch 12 times, most recently from 3491853 to c2b6e44 Compare September 16, 2023 08:12
Comment on lines 462 to 463
FileUtils.getFileLineNumberFromDir(testResources.getLeft())
+ "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FileUtils.getFileLineNumberFromDir(testResources.getLeft())
+ "");
FileUtils.getFileLineNumberFromDir(testResources.getLeft()));

Comment on lines -147 to -149
JobStatus jobStatus =
seaTunnelServer.getCoordinatorService().getJobStatus(Long.parseLong(jobId));
Assertions.assertEquals(JobStatus.RUNNING, jobStatus);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Hisoka-X
Hisoka-X previously approved these changes Oct 25, 2023
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passed.

@hailin0
Copy link
Member

hailin0 commented Oct 25, 2023

LGTM if test passed.

+1

@EricJoy2048 EricJoy2048 merged commit 592ee00 into apache:dev Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [CI][E2E] connector-seatunnel-e2e-base failed randomly
5 participants