New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Update PR template to add test and user change question #5486
Conversation
Good Job, Can you add some well done tests or document links for contributors to refer to directly? |
Code changes involve many different modules, and providing test cases of a certain module may mislead the contributer. The document too, and the all doc link already in |
I found most of the PRs don't check the data type and value in Sink Connector e2e. And many new connector document did not use our latest document specification, but instead used the old one. |
Sounds reasonable, I add some comment for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…he#5486) * [INFRA] Update PR template to add test and user change question * [INFRA] Update PR template to add test and user change question * update
Purpose of this pull request
Update PR template to make sure contributer to check the change with test covered and it is or not change user-facing change. It will look like this PR msg.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unnecessary.
Check list
New License Guide
release-note
.