Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove connector/seatunnel directory #5489

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR remove connector/seatunnel directory in binary package. Move all connector to connector directory. Because we only have one series connector.

Tested in local, also if CI passed means change work fine.

Check list

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update bin/install-plugin.sh?

@Hisoka-X
Copy link
Member Author

update bin/install-plugin.sh?

oh, I forgot it. Thanks for remind.

@ruanwenjun
Copy link
Member

update bin/install-plugin.sh?

update bin/install-plugin.cmd

@Hisoka-X
Copy link
Member Author

update bin/install-plugin.sh?

update bin/install-plugin.cmd

Done

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit 7b43ff8 into apache:dev Sep 15, 2023
52 of 55 checks passed
@Hisoka-X Hisoka-X deleted the remove-seatunnel-dict branch September 15, 2023 03:14
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants