[BUGFIX][Catalog] oracle catalog create table repeat and oracle pg null point #5517
Conversation
XiaoJiang521
changed the title
|
Hi, could you add some comment follow the template? To make sure reviewer to know this PR want to do what. |
Done |
|
Could you add some comment like this? Shall we add some test case for this? |
| } | ||
|
|
||
| @Override | ||
| protected String getTableName(TablePath tablePath) { | ||
| return tablePath.getSchemaAndTableName().toUpperCase(); | ||
| return tablePath.getSchemaAndTableName(); |
There was a problem hiding this comment.
This method can be removed now as it's identical to super method.
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class JdbcOracleLowerTableIT extends AbstractJdbcIT { |
There was a problem hiding this comment.
I think it would be better to name it JdbcOracleLowercaseTableIT.
There was a problem hiding this comment.
ok ！Then I added a new part6 because e2e always reports errors
Added a case for oracle lowercase table creation. If the catalogname is null, go heterogeneous table creation. No case should be added |
Purpose of this pull request
AbstractJdbcCatalog The catalogName passed down may be null，In this case, the automatic table construction will report an error, and can not distinguish the same table and heterogeneous table construction, will become all heterogeneous table construction
Previously, dialect was not added to the database sql. After dialect was added, oracle table may appear lowercase name, so determining whether the table exists will never exist, because the table name is converted to uppercase, but the actual table name is lowercase，And there will be an error building the statement
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.