Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix ReadonlyConfig lose key error #5565

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Fix ReadonlyConfig will lose key, it introduced by #5534

Does this PR introduce any user-facing change?

No

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X added the bug label Sep 26, 2023
@hailin0 hailin0 added the api label Sep 26, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 36754cc into apache:dev Sep 28, 2023
4 checks passed
@Hisoka-X Hisoka-X deleted the fix-readonly-lose-key branch October 8, 2023 03:04
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants