Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2][File] Support read empty directory #5591

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[Feature][Connector-V2][File] Support read empty directory #5591

merged 2 commits into from
Oct 11, 2023

Conversation

TyrantLucifer
Copy link
Member

@TyrantLucifer TyrantLucifer commented Oct 4, 2023 •
edited
Loading

Purpose of this pull request

Support sync empty directory for file connector.

Does this PR introduce any user-facing change?

No

How was this patch tested?

I add the new test case in LocalFileE2E.

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 7, 2023

I think you should answer these question.
image

@Hisoka-X Hisoka-X added the feature New feature label Oct 7, 2023
@TyrantLucifer
Copy link
Member Author

I think you should answer these question.

image

Done

Hisoka-X
Hisoka-X approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Carl-Zhou-CN
Carl-Zhou-CN approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0 hailin0 merged commit 1f58f22 into apache:dev Oct 11, 2023
5 checks passed
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
@TyrantLucifer
[Feature][Connector-V2][File] Support read empty directory (apache#5591)
613534f
@hailin0 hailin0 mentioned this pull request Nov 8, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 feature New feature file reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TyrantLucifer @Hisoka-X @hailin0 @Carl-Zhou-CN