Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Adjust the phase of spotless plugin for release plugin. #5607

Merged
merged 1 commit into from Oct 11, 2023

Conversation

FlechazoW
Copy link
Contributor

Purpose of this pull request

[Improve] Adjust the phase of spotless plugin for release plugin.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

Does this will affect CI? After this change, the CI will check style or not?

@EricJoy2048
Copy link
Member

Does this will affect CI? After this change, the CI will check style or not?

The default value of skip.spotless is false, So the spotless will skip only when build with -Darguments="-Dskip.spotless=true"

@EricJoy2048 EricJoy2048 merged commit 6500c59 into apache:dev Oct 11, 2023
4 checks passed
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants