Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Change hard code config key to reference #5618

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR change hard code config key string to reference from hazelcast. Improve code rubustness.

Does this PR introduce any user-facing change?

No

How was this patch tested?

exist test.

Check list

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 2b3fc6c into apache:dev Oct 16, 2023
4 checks passed
@Hisoka-X Hisoka-X deleted the change-hard-code-config branch October 16, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants